* [U-Boot] [PATCH] mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register @ 2013-04-09 21:29 Philip Paeps 2013-04-09 22:44 ` [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers Philip Paeps 0 siblings, 1 reply; 4+ messages in thread From: Philip Paeps @ 2013-04-09 21:29 UTC (permalink / raw) To: u-boot This makes mxc_iomux_set_input() work as expected. Signed-off-by: Philip Paeps <philip@paeps.cx> --- arch/arm/cpu/arm1136/mx35/iomux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/cpu/arm1136/mx35/iomux.c b/arch/arm/cpu/arm1136/mx35/iomux.c index a302575..d6f4ced 100644 --- a/arch/arm/cpu/arm1136/mx35/iomux.c +++ b/arch/arm/cpu/arm1136/mx35/iomux.c @@ -35,7 +35,7 @@ enum iomux_reg_addr { IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324, /* last MUX control */ IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328, /* Pad control */ IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794, /* last Pad control */ - IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */ + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */ IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */ }; -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers 2013-04-09 21:29 [U-Boot] [PATCH] mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register Philip Paeps @ 2013-04-09 22:44 ` Philip Paeps 2013-04-10 6:23 ` Stefano Babic 2013-04-16 11:01 ` Stefano Babic 0 siblings, 2 replies; 4+ messages in thread From: Philip Paeps @ 2013-04-09 22:44 UTC (permalink / raw) To: u-boot This makes mxc_iomux_set_input() work correctly. Previously, the incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() to write to the wrong register, possibly resulting in unexpected behaviour. Signed-off-by: Philip Paeps <philip@paeps.cx> --- Changes in v2: - While here, also correct the offset of the last pad control register. This is mostly cosmetic. arch/arm/cpu/arm1136/mx35/iomux.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/arm1136/mx35/iomux.c b/arch/arm/cpu/arm1136/mx35/iomux.c index a302575..698909e 100644 --- a/arch/arm/cpu/arm1136/mx35/iomux.c +++ b/arch/arm/cpu/arm1136/mx35/iomux.c @@ -34,8 +34,8 @@ enum iomux_reg_addr { IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4, /* MUX control */ IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324, /* last MUX control */ IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328, /* Pad control */ - IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794, /* last Pad control */ - IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */ + IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4, /* last Pad control */ + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */ IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */ }; -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers 2013-04-09 22:44 ` [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers Philip Paeps @ 2013-04-10 6:23 ` Stefano Babic 2013-04-16 11:01 ` Stefano Babic 1 sibling, 0 replies; 4+ messages in thread From: Stefano Babic @ 2013-04-10 6:23 UTC (permalink / raw) To: u-boot On 10/04/2013 00:44, Philip Paeps wrote: > This makes mxc_iomux_set_input() work correctly. Previously, the > incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() > to write to the wrong register, possibly resulting in unexpected > behaviour. > > Signed-off-by: Philip Paeps <philip@paeps.cx> > --- Hi Philip, > Changes in v2: > - While here, also correct the offset of the last pad control > register. This is mostly cosmetic. > > arch/arm/cpu/arm1136/mx35/iomux.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/arm1136/mx35/iomux.c b/arch/arm/cpu/arm1136/mx35/iomux.c > index a302575..698909e 100644 > --- a/arch/arm/cpu/arm1136/mx35/iomux.c > +++ b/arch/arm/cpu/arm1136/mx35/iomux.c > @@ -34,8 +34,8 @@ enum iomux_reg_addr { > IOMUXSW_MUX_CTL = IOMUXC_BASE_ADDR + 4, /* MUX control */ > IOMUXSW_MUX_END = IOMUXC_BASE_ADDR + 0x324, /* last MUX control */ > IOMUXSW_PAD_CTL = IOMUXC_BASE_ADDR + 0x328, /* Pad control */ > - IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x794, /* last Pad control */ > - IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */ > + IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4, /* last Pad control */ > + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */ > IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */ > }; You're right, offset were wrong. Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers 2013-04-09 22:44 ` [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers Philip Paeps 2013-04-10 6:23 ` Stefano Babic @ 2013-04-16 11:01 ` Stefano Babic 1 sibling, 0 replies; 4+ messages in thread From: Stefano Babic @ 2013-04-16 11:01 UTC (permalink / raw) To: u-boot On 10/04/2013 00:44, Philip Paeps wrote: > This makes mxc_iomux_set_input() work correctly. Previously, the > incorrect offset of IOMUXSW_INPUT_CTL caused mxc_iomux_set_input() > to write to the wrong register, possibly resulting in unexpected > behaviour. > > Signed-off-by: Philip Paeps <philip@paeps.cx> > --- Applied to u-boot-imx, -next branch, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-16 11:01 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-09 21:29 [U-Boot] [PATCH] mx35 iomux: correct offset of IOMUXSW_INPUT_CTL register Philip Paeps 2013-04-09 22:44 ` [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers Philip Paeps 2013-04-10 6:23 ` Stefano Babic 2013-04-16 11:01 ` Stefano Babic
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox