[U-Boot] [PATCH] imx: Add titanium board support (i.MX6 based)

Fabio Estevam
2013-04-11T03:36:36Z

Hi Stefan,

On Wed, Apr 10, 2013 at 4:17 AM, Stefan Roese <sr@denx.de> wrote:
> Titanium is a i.MX6 based board from ProjectionDesign / Barco. This
> patch adds support for this board with the newly introduced NAND
> support for i.MX6.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> MAINTAINERS | 2 +
> board/freescale/titanium/Makefile | 36 ++++
> board/freescale/titanium/imximage.cfg | 181 +++++++++++++++++
> board/freescale/titanium/titanium.c | 372 ++++++++++++++++++++++++++++++++++
> boards.cfg | 1 +
> include/configs/titanium.h | 274 +++++++++++++++++++++++++
> 6 files changed, 866 insertions(+)
> create mode 100644 board/freescale/titanium/Makefile
> create mode 100644 board/freescale/titanium/imximage.cfg
> create mode 100644 board/freescale/titanium/titanium.c
> create mode 100644 include/configs/titanium.h

It would be helpful to add a small README explaining how to flash and
boot from NAND.

> +/*
> + * Siste adresse i RAM. Starter p? 0x10000000 og med 512MB blir dette
> + * siste 0x30000000 som er 768MB - sabrelite: 0x00000027
> + */

Maybe translate it to English?

> +#define CONFIG_MACH_TYPE 3769

You could do:

#define MACH_TYPE_TITANIUM 3769
#define CONFIG_MACH_TYPE MACH_TYPE_TITANIUM

> +
> +#include <asm/arch/imx-regs.h>
> +#include <asm/imx-common/gpio.h>

You could move the defines to the start of this file.

> +/* Size of malloc() pool */
> +#define CONFIG_SYS_MALLOC_LEN (2 * 1024 * 1024)

What about SZ_2M ?

> +#define CONFIG_ARP_TIMEOUT 200UL

Is this needed?

> +/* Physical Memory Map */
> +#define CONFIG_NR_DRAM_BANKS 1
> +#define PHYS_SDRAM MMDC0_ARB_BASE_ADDR
> +#define PHYS_SDRAM_SIZE (1u * 512 * 1024 * 1024)

What about using SZ_512M instead? Same for other (x << y) sizes passed
in other places.

Regards,

Fabio Estevam