[U-Boot] [PATCH] imx: Add titanium board support (i.MX6 based)

Fabio Estevam
2013-04-11T15:48:04Z

Hi Stefan,

On Wed, Apr 10, 2013 at 4:17 AM, Stefan Roese <sr@denx.de> wrote:

> +u32 get_board_rev(void)
> +{
> + return get_cpu_rev();
> +}

You can drop this, since I recently sent a patch that places it on a
common location.

> +/* Physical Memory Map */
> +#define CONFIG_NR_DRAM_BANKS 1
> +#define PHYS_SDRAM MMDC0_ARB_BASE_ADDR
> +#define PHYS_SDRAM_SIZE (1u * 512 * 1024 * 1024)

When I initially submitted the Wandboard support patch, Wolfgang
commented that this '1u' is not really needed, and then I used
SZ_512M, which provides better readability. Maybe you can do the same
here?

Regards,

Fabio Estevam