From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spi: mxc_spi: Set master mode for all channels
Date: Sat, 13 Apr 2013 17:50:15 +0200 [thread overview]
Message-ID: <51697EB7.5080406@denx.de> (raw)
In-Reply-To: <CAOMZO5DquQd+gMxrB-gvNNwLAKj7OPKLsaeriRRgTEyNBL_53w@mail.gmail.com>
On 10/04/2013 14:01, Fabio Estevam wrote:
> Hi Stefano,
>
> On Wed, Apr 10, 2013 at 3:10 AM, Stefano Babic <sbabic@denx.de> wrote:
>
>> I am afraid you are breaking MX3x / MX25 because you add
>> MXC_CSPICTRL_MODE_MASK only to MX5 / MX6.
>
> It will not break other platforms because this code is protected with
> a "#ifdef MXC_ECSPI".
>
> And MXC_ECSPI is only defined on mx5/mx6:
>
> arch/arm/include/asm/arch-mx5/imx-regs.h:#define MXC_ECSPI
> arch/arm/include/asm/arch-mx6/imx-regs.h:#define MXC_ECSPI
>
> ,so we are safe here.
Thanks, you're right.
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-04-13 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 23:06 [U-Boot] [PATCH v2] spi: mxc_spi: Set master mode for all channels Fabio Estevam
2013-04-10 6:10 ` Stefano Babic
2013-04-10 12:01 ` Fabio Estevam
2013-04-13 15:50 ` Stefano Babic [this message]
2013-04-14 7:08 ` Dirk Behme
2013-05-01 5:38 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51697EB7.5080406@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox