From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 13 Apr 2013 17:50:15 +0200 Subject: [U-Boot] [PATCH v2] spi: mxc_spi: Set master mode for all channels In-Reply-To: References: <1365548785-28684-1-git-send-email-festevam@gmail.com> <51650244.4050608@denx.de> Message-ID: <51697EB7.5080406@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/04/2013 14:01, Fabio Estevam wrote: > Hi Stefano, > > On Wed, Apr 10, 2013 at 3:10 AM, Stefano Babic wrote: > >> I am afraid you are breaking MX3x / MX25 because you add >> MXC_CSPICTRL_MODE_MASK only to MX5 / MX6. > > It will not break other platforms because this code is protected with > a "#ifdef MXC_ECSPI". > > And MXC_ECSPI is only defined on mx5/mx6: > > arch/arm/include/asm/arch-mx5/imx-regs.h:#define MXC_ECSPI > arch/arm/include/asm/arch-mx6/imx-regs.h:#define MXC_ECSPI > > ,so we are safe here. Thanks, you're right. Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================