[U-Boot] [PATCH 3/5] ARM: OMAP: Correct save_boot_params and replace with 'C' function

Sricharan R
2013-04-15T15:33:31Z

On Monday 15 April 2013 08:58 PM, Tom Rini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/15/2013 11:08 AM, Sricharan R wrote:
>> Currently save_boot_params saves the boot parameters passed from
>> romcode. But this is not stored in a writable location
>> consistently. So the current code would not work for a 'XIP' boot.
>> Change this by saving the boot parameters in 'gd' which is always
>> writable. Also add a 'C' function instead of an assembly code that
>> is more readable.
>>
>> Signed-off-by: Sricharan R <r.sricharan@ti.com> --- There is a
>> checkpatch warning because of multiple assignments. The code looks
>> readable this way.
>>
>
> What/where?
>
In the below line pf the patch.
gd->arch.omap_boot_params.omap_bootdevice = boot_device =

> [snip]
>> + if ((boot_device >= BOOT_DEVICE_XIP) && + (boot_device <=
>> BOOT_DEVICE_MMC2)) {
>
> This will need to be rebased to use MMC_BOOT_DEVICES_START/END and I
> know you didn't test from eMMC on omap5_uevm then.
>
Yes, i was aware of this. Infact i saw before this series that
emmc was broken and your patch was fixing that. When i started this
series, your patch was not merged then. I can rebase on V2.

Regards,
Sricharan