From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sricharan R <r.sricharan@ti.com>
Date: Tue, 16 Apr 2013 09:34:00 +0530
Subject: [U-Boot] [PATCH 3/5] ARM: OMAP: Correct save_boot_params and
 replace with 'C' function
In-Reply-To: <998DF6E6-9F7A-4AD9-B046-76590EA186C0@prograde.net>
References: <1366038520-7492-1-git-send-email-r.sricharan@ti.com>
	<1366038520-7492-4-git-send-email-r.sricharan@ti.com>
	<998DF6E6-9F7A-4AD9-B046-76590EA186C0@prograde.net>
Message-ID: <516CCDB0.6080407@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 15 April 2013 09:52 PM, Michael Cashwell wrote:
> Hi Sricharan,
> 
> I very much like how you've structured this. A vast improvement!
> 
> I haven't yet tried to apply the whole series but have one quick comment. In the new function:
> 
> static void save_omap_boot_params(void)
> {
> ...
>   if (!(omap_hw_init_context() ==
>        OMAP_INIT_CONTEXT_UBOOT_AFTER_SPL)) {
>       ...
>   } else {
>       ...
>   }
> 
> wouldn't it be clearer to drop the boolean negation "!" and exchange the if/else bodies?
> 
 hmm, will do and add a comment as well.

Regards,
 Sricharan