From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Kushwaha Date: Tue, 16 Apr 2013 10:19:51 +0530 Subject: [U-Boot] [PATCH 1/5][v4] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399 In-Reply-To: <516CD16B.6010902@freescale.com> References: <1366020768-11600-1-git-send-email-prabhakar@freescale.com> <1366062094.20212.3@snotra> <516CD16B.6010902@freescale.com> Message-ID: <516CD86F.6000105@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/16/2013 09:49 AM, Prabhakar Kushwaha wrote: > On 04/16/2013 03:11 AM, Scott Wood wrote: >> On 04/15/2013 05:12:48 AM, Prabhakar Kushwaha wrote: >>> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> index dacfdd1..439a873 100644 >>> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c >>> @@ -25,7 +25,7 @@ >>> >>> DECLARE_GLOBAL_DATA_PTR; >>> >>> -#if defined(CONFIG_SYS_FSL_ERRATUM_IFC_A003399) && >>> !defined(CONFIG_SYS_RAMBOOT) >>> +#ifdef CONFIG_A003399_NOR_WORKAROUND >> >> Won't this break bisectability since you don't define >> CONFIG_A003399_NOR_WORKAROUND until a later patch? >> > > This workaround is only required for P1010. so for other SoC it should > not be defined. For P1010 it is defined in P10101RDB.h > also all patches of a patch set should be applied at once. > > may be I am unable to understand the question. > is it related to bisectability feature of git? in that case there can be 2 possible solutions a) change the patch set sequence b) combine patch. but changes are in arch/powerpc/ and boards files. will it be right to combine together? Please suggest!! Regards, Prabhakar