From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Tue, 16 Apr 2013 16:15:38 +0200 Subject: [U-Boot] [PATCH] make hang() a weak function In-Reply-To: References: <1366107249-24547-1-git-send-email-andreas.devel@googlemail.com> <20130416133621.40db0a42@lilith> <516D39CF.9020907@gmail.com> <20130416122229.BB9E0200568@gemini.denx.de> <516D4B00.9030102@gmail.com> <20130416130515.04A83200568@gemini.denx.de> <516D52EE.1040402@gmail.com> Message-ID: <516D5D0A.20403@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Graeme, On 04/16/2013 03:35 PM, Graeme Russ wrote: > Hi Andreas, > > On Tue, Apr 16, 2013 at 11:32 PM, Andreas Bie?mann > > wrote: >> >> Dear Wolfgang, >> >> On 04/16/2013 03:05 PM, Wolfgang Denk wrote: >> > Dear Andreas, >> > >> > In message <516D4B00.9030102@gmail.com > > you wrote: > I think that ultimately there should only be a single hang() function Ok. >> > Note that hang() is not supposed to do anything else, it just hangs >> > the system. If you have a debugger attached, you will be able to do a >> > simple stack backtrace and see exactly where you are hanging, and why. >> >> Well, for this specific board I plan to panic() on wrong hardware >> detection (which will in turn call hang()). My requirements say that I >> have to visualize this state then, I thought it would be a good idea to >> blink some lights in the endless loop in hang() for this specific board. >> >> > If you think you need to have specialized code, you are doing >> > something wrong. >> >> Really? How would you solve this requirement? > > Doesn't it make sense to use panic()? In my opinion it makes sense to panic(). In my special case I also need to hang() when panic(). The next question is then how to visualize the (end-)user of that device that we hang(). Best regards Andreas Bie?mann