From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Jackson <mpfj-list@mimc.co.uk>
Date: Tue, 16 Apr 2013 20:31:19 +0100
Subject: [U-Boot] [PATCH] Add NanoBone board support
In-Reply-To: <20130416192752.GH11956@bill-the-cat>
References: <516D680A.3030903@mimc.co.uk> <20130416154820.GD11956@bill-the-cat>
	<516DA305.10707@mimc.co.uk> <516DA59D.9030203@mimc.co.uk>
	<20130416192752.GH11956@bill-the-cat>
Message-ID: <516DA707.7030500@mimc.co.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 16/04/13 20:27, Tom Rini wrote:
> On Tue, Apr 16, 2013 at 08:25:17PM +0100, Mark Jackson wrote:
>> On 16/04/13 20:14, Mark Jackson wrote:
>>> On 16/04/13 16:48, Tom Rini wrote:
>>>> On Tue, Apr 16, 2013 at 04:02:34PM +0100, Mark Jackson wrote:
>>
>> <snip>
>>
>>>>> +#define    CONFIG_SYS_NAND_ECCTOTAL    (CONFIG_SYS_NAND_ECCBYTES * \
>>>>> +                        CONFIG_SYS_NAND_ECCSTEPS)
>>>>> +
>>>>> +#define    CONFIG_SYS_NAND_U_BOOT_START    CONFIG_SYS_TEXT_BASE
>>>>
>>>> Another problem duplicated from am335x_evm.h :(
>>>
>>> I'll add it to the "remove duplicates" patch.
>>
>> Replied a bit too soon on this one ... I thought they were
>> duplicated, but they're not.
>>
>> what's the problem with these lines ?
>
> '#define<tab>' not '#define<space>'.  A general fixup patch is fine.

Actually, neither CONFIG_SYS_NAND_ECCTOTAL nor CONFIG_SYS_NAND_ECCSTEPS 
are used anywhere in the code !!

I'll just remove them.