From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] exynos: Correct use of 64-bit division
Date: Wed, 17 Apr 2013 11:10:09 +0900 [thread overview]
Message-ID: <516E0481.2010807@samsung.com> (raw)
In-Reply-To: <1365863202-22713-1-git-send-email-sjg@chromium.org>
On 13/04/13 23:26, Simon Glass wrote:
> The current code is causing errors like this on my toolchains:
>
> /usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.22/
> ld.bfd.real: failed to merge target specific data of file /usr/lib/gcc/
> armv7a-cros-linux-gnueabi/4.7.x-google/libgcc.a(_divdi3.o)
>
> Use do_div() to avoid this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/cpu/armv7/s5p-common/timer.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv7/s5p-common/timer.c b/arch/arm/cpu/armv7/s5p-common/timer.c
> index 6a0fa58..4adfaae 100644
> --- a/arch/arm/cpu/armv7/s5p-common/timer.c
> +++ b/arch/arm/cpu/armv7/s5p-common/timer.c
> @@ -24,6 +24,7 @@
> */
>
> #include <common.h>
> +#include <div64.h>
> #include <asm/io.h>
> #include <asm/arch/pwm.h>
> #include <asm/arch/clk.h>
> @@ -76,6 +77,8 @@ int timer_init(void)
> */
> unsigned long get_timer(unsigned long base)
> {
> + unsigned long long time_ms;
> +
> ulong now = timer_get_us_down();
>
> /*
> @@ -87,7 +90,9 @@ unsigned long get_timer(unsigned long base)
> gd->arch.lastinc = now;
>
> /* Divide by 1000 to convert from us to ms */
> - return gd->arch.timer_reset_value / 1000 - base;
> + time_ms = gd->arch.timer_reset_value;
> + do_div(time_ms, 1000);
> + return time_ms - base;
> }
>
> unsigned long timer_get_us(void)
>
applied to u-boot-samsung
Thanks,
Minkyu Kang.
prev parent reply other threads:[~2013-04-17 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 14:26 [U-Boot] [PATCH 1/2] exynos: Correct use of 64-bit division Simon Glass
2013-04-13 14:26 ` [U-Boot] [PATCH 2/2] exynos: fdt: Add TMU node for snow Simon Glass
2013-04-17 2:10 ` Minkyu Kang
2013-04-17 2:10 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E0481.2010807@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox