[U-Boot] [PATCH v3 0/5] consolidate hang()

Simon Glass
2013-04-25T21:44:15Z

Hi Andreas,

On Fri, Apr 19, 2013 at 1:48 AM, Andreas Bie?mann
<andreas.devel@googlemail.com> wrote:
> This series started with intention to make a hung board visualize the
> (end-)user that it does hang(). The first approach was to make all the
> different hang() functions weak and provide board specific versions to
> implement the 'visualization' there.
> After some discussion it turned out, that there is still an interface to
> visualize such states to the user: the 'bootstage' stuff.
>
> BTW:
> This is my first try sending a series with patman. All I can say is:
> patman is really cool ;)
>
> The 'microblaze: fix style in board.c' is an leftover from the first approach.
>
> The 'nios2: fix style in board.c' is an leftover from the first approach.
>
> The 'lib: consolidate hang()' is build tested on arm and avr32. It may
> produces errors on other arches like ppc cause the previous SPL inlined hang()
> function was also removed. We need to discuss if we always pull in the
> libgeneric unconditional into SPL or provide a second hang() for those boards
> which do not link against libgeneric in SPL.
>
> Since v2 got a complete (compile-)test on powerpc by Wolfgang I think we can
> stick with the current solution. v3 includes some minor changes mentioned in
> the changelog of respective patches.

This series tested on snow with CONFIG_SYS_GENERIC_BOARD enabled. No
warnings or problems noted and hang() still works.

Tested-by: Simon Glass <sjg@chromium.org>
Acked-by: Simon Glass <sjg@chromium.org>

>
> Changes in v3:
> * shorten error string for 'no FDT'
> * remove unnecessarily added linux/compiler.h
> * fix typo in new hang() docu
> * use simplified macro for SPL_LIBCOMMON_SUPPORT as suggested by Beno?t
>
> Changes in v2:
> * delete all hang() and provide generic lib/hang.c
>
> Andreas Bie?mann (5):
> microblaze: fix style in board.c
> nios2: fix style in board.c.
> mx31pdk: add CONFIG_SPL_LIBGENERIC_SUPPORT
> tx25: add CONFIG_SPL_LIBGENERIC_SUPPORT
> lib: consolidate hang()
>