[U-Boot] [PATCH v2 1/5] microblaze: fix style in board.c

Michal Simek
2013-04-17T11:44:44Z

On 04/17/2013 01:02 PM, Andreas Bie?mann wrote:
> Make microblaze's board.c checkpatch clean.
>
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>
> ---
> Changes in v2: None
>
> arch/microblaze/lib/board.c | 64 +++++++++++++++++++++----------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
> index a7c2f76..846ffe1 100644
> --- a/arch/microblaze/lib/board.c
> +++ b/arch/microblaze/lib/board.c
> @@ -71,15 +71,15 @@ void board_init_f(ulong not_used)
> {
> bd_t *bd;
> init_fnc_t **init_fnc_ptr;
> - gd = (gd_t *) (CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_GBL_DATA_OFFSET);
> - bd = (bd_t *) (CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_GBL_DATA_OFFSET \
> + gd = (gd_t *)(CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_GBL_DATA_OFFSET);
> + bd = (bd_t *)(CONFIG_SYS_SDRAM_BASE + CONFIG_SYS_GBL_DATA_OFFSET
> - GENERATED_BD_INFO_SIZE);
> #if defined(CONFIG_CMD_FLASH)
> ulong flash_size = 0;
> #endif
> asm ("nop"); /* FIXME gd is not initialize - wait */
> - memset ((void *)gd, 0, GENERATED_GBL_DATA_SIZE);
> - memset ((void *)bd, 0, GENERATED_BD_INFO_SIZE);
> + memset((void *)gd, 0, GENERATED_GBL_DATA_SIZE);
> + memset((void *)bd, 0, GENERATED_BD_INFO_SIZE);
> gd->bd = bd;
> gd->baudrate = CONFIG_BAUDRATE;
> bd->bi_baudrate = CONFIG_BAUDRATE;
> @@ -105,57 +105,56 @@ void board_init_f(ulong not_used)
> * aka CONFIG_SYS_MONITOR_BASE - Note there is no need for reloc_off
> * as our monitory code is run from SDRAM
> */
> - mem_malloc_init (CONFIG_SYS_MALLOC_BASE, CONFIG_SYS_MALLOC_LEN);
> + mem_malloc_init(CONFIG_SYS_MALLOC_BASE, CONFIG_SYS_MALLOC_LEN);
>
> serial_initialize();
>
> for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
> - WATCHDOG_RESET ();
> - if ((*init_fnc_ptr) () != 0) {
> - hang ();
> - }
> + WATCHDOG_RESET();
> + if ((*init_fnc_ptr) () != 0)
> + hang();
> }
>
> #ifdef CONFIG_OF_CONTROL
> /* For now, put this check after the console is ready */
> - if (fdtdec_prepare_fdt()) {
> - panic("** CONFIG_OF_CONTROL defined but no FDT - please see "
> - "doc/README.fdt-control");
> - } else
> + if (fdtdec_prepare_fdt())
> + panic(
> + "** CONFIG_OF_CONTROL defined but no FDT - please see doc/README.fdt-control");

This is quite weird coding style.
I know that the previous one doesn't pass but this is also weird.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID:
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform