[U-Boot] [PATCH v2 1/5] microblaze: fix style in board.c

Michal Simek
2013-04-17T11:56:04Z

On 04/17/2013 01:54 PM, Andreas Bie?mann wrote:
> Dear Michal Simek,
>
> On 04/17/2013 01:44 PM, Michal Simek wrote:
>> On 04/17/2013 01:02 PM, Andreas Bie?mann wrote:
>>> Make microblaze's board.c checkpatch clean.
>>>
>>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>>>
>>> ---
>>> Changes in v2: None
>>>
>>> arch/microblaze/lib/board.c | 64 +++++++++++++++++++++----------------------
>>> 1 file changed, 32 insertions(+), 32 deletions(-)
>>>
>>> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
>>> index a7c2f76..846ffe1 100644
>>> --- a/arch/microblaze/lib/board.c
>>> +++ b/arch/microblaze/lib/board.c
>>> @@ -71,15 +71,15 @@ void board_init_f(ulong not_used)
>
>
>>> #ifdef CONFIG_OF_CONTROL
>>> /* For now, put this check after the console is ready */
>>> - if (fdtdec_prepare_fdt()) {
>>> - panic("** CONFIG_OF_CONTROL defined but no FDT - please see "
>>> - "doc/README.fdt-control");
>>> - } else
>>> + if (fdtdec_prepare_fdt())
>>> + panic(
>>> + "** CONFIG_OF_CONTROL defined but no FDT - please see doc/README.fdt-control");
>>
>> This is quite weird coding style.
>> I know that the previous one doesn't pass but this is also weird.
>
> I tried to not change the content. How about:
> | + if (fdtdec_prepare_fdt())
> | + panic("** No FDT - please see doc/README.fdt-control");

yep. Much better.

Not sure how you want to handle this patch. If in the series with hang()
then write there my
Reviewed-by: Michal Simek <monstr@monstr.eu>

If you want to add to my microblaze custodian tree, please let me know.

I think I had done this some time ago but never push this to mainline.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID:
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform