[U-Boot] [PATCH v2 1/5] microblaze: fix style in board.c

Andreas Bießmann
2013-04-17T11:54:51Z

Dear Michal Simek,

On 04/17/2013 01:44 PM, Michal Simek wrote:
> On 04/17/2013 01:02 PM, Andreas Bie?mann wrote:
>> Make microblaze's board.c checkpatch clean.
>>
>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>>
>> ---
>> Changes in v2: None
>>
>> arch/microblaze/lib/board.c | 64 +++++++++++++++++++++----------------------
>> 1 file changed, 32 insertions(+), 32 deletions(-)
>>
>> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
>> index a7c2f76..846ffe1 100644
>> --- a/arch/microblaze/lib/board.c
>> +++ b/arch/microblaze/lib/board.c
>> @@ -71,15 +71,15 @@ void board_init_f(ulong not_used)

>> #ifdef CONFIG_OF_CONTROL
>> /* For now, put this check after the console is ready */
>> - if (fdtdec_prepare_fdt()) {
>> - panic("** CONFIG_OF_CONTROL defined but no FDT - please see "
>> - "doc/README.fdt-control");
>> - } else
>> + if (fdtdec_prepare_fdt())
>> + panic(
>> + "** CONFIG_OF_CONTROL defined but no FDT - please see doc/README.fdt-control");
>
> This is quite weird coding style.
> I know that the previous one doesn't pass but this is also weird.

I tried to not change the content. How about:
| + if (fdtdec_prepare_fdt())
| + panic("** No FDT - please see doc/README.fdt-control");

Best regards

Andreas Bie?mann