public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pierre AUBERT <p.aubert@staubli.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL
Date: Fri, 19 Apr 2013 08:17:28 +0200	[thread overview]
Message-ID: <5170E178.1080201@staubli.com> (raw)
In-Reply-To: <20130418173739.88D9A20019A@gemini.denx.de>

Hello Wolfgang,

Le 18/04/2013 19:37, Wolfgang Denk a ?crit :
> Dear Pierre Aubert,
>
> In message <1366296086-22394-1-git-send-email-p.aubert@staubli.com> you wrote:
>> The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the
>> support of the i.MX6DL. The config file and the board directory are renamed
>> to remove the reference to the MX6Q.
> Formal issues:
>
> - entry to MAINTAINERS file missing
Fabio Estevam is already the maintainer of the SabreSD. I didn't add any 
new boad, I've just add the support for the i.MX6DL on this board. I 
will update the MAINTAINERS file.

> - there are 2 checkpatch warnings ("please, no spaces at the start of
>    a line") that need to be fixed.
Will be fixed
>
>>   int checkboard(void)
>>   {
>> -	puts("Board: MX6Q-SabreSD\n");
>> -
>> +#ifdef CONFIG_MX6Q
>> +    puts("Board: MX6Q-SabreSD\n");
>> +#else
>> +    puts("Board: MX6DL-SabreSD\n");
>> +#endif
> Can we please avoid such #ifdef's?  Here, we could for example refer
> to the board name (CONFIG_SYS_BOARD if you like the name, or some
> custom defined CONFIG_BOARD_NAME like other boards do).
>
The board name in MX6-SabreSD. The Soc type (dual or quad core) is 
already printed by print_cpuinfo.
> Best regards,
>
> Wolfgang Denk
>
Best regards
Pierre Aubert

  reply	other threads:[~2013-04-19  6:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 14:41 [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL Pierre Aubert
2013-04-18 17:37 ` Wolfgang Denk
2013-04-19  6:17   ` Pierre AUBERT [this message]
2013-04-19  8:15   ` Stefano Babic
2013-04-19  8:23     ` Pierre AUBERT
2013-04-19  8:27     ` Eric Bénard
2013-04-19  9:00       ` Stefano Babic
2013-04-18 17:51 ` Fabio Estevam
2013-04-19  5:27   ` Pierre AUBERT
2013-04-22  6:12 ` [U-Boot] [PATCH v2 1/2] imx: Complete the pin definitions for the i.MX6DL / i.MX6Solo Pierre Aubert
2013-04-22  6:12   ` [U-Boot] [PATCH v2 2/2] imx: Add support for the SabreSD shipped with i.MX6DL Pierre Aubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5170E178.1080201@staubli.com \
    --to=p.aubert@staubli.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox