From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre AUBERT <p.aubert@staubli.com>
Date: Fri, 19 Apr 2013 08:17:28 +0200
Subject: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with
 i.MX6DL
In-Reply-To: <20130418173739.88D9A20019A@gemini.denx.de>
References: <1366296086-22394-1-git-send-email-p.aubert@staubli.com>
	<20130418173739.88D9A20019A@gemini.denx.de>
Message-ID: <5170E178.1080201@staubli.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Wolfgang,

Le 18/04/2013 19:37, Wolfgang Denk a ?crit :
> Dear Pierre Aubert,
>
> In message <1366296086-22394-1-git-send-email-p.aubert@staubli.com> you wrote:
>> The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the
>> support of the i.MX6DL. The config file and the board directory are renamed
>> to remove the reference to the MX6Q.
> Formal issues:
>
> - entry to MAINTAINERS file missing
Fabio Estevam is already the maintainer of the SabreSD. I didn't add any 
new boad, I've just add the support for the i.MX6DL on this board. I 
will update the MAINTAINERS file.

> - there are 2 checkpatch warnings ("please, no spaces at the start of
>    a line") that need to be fixed.
Will be fixed
>
>>   int checkboard(void)
>>   {
>> -	puts("Board: MX6Q-SabreSD\n");
>> -
>> +#ifdef CONFIG_MX6Q
>> +    puts("Board: MX6Q-SabreSD\n");
>> +#else
>> +    puts("Board: MX6DL-SabreSD\n");
>> +#endif
> Can we please avoid such #ifdef's?  Here, we could for example refer
> to the board name (CONFIG_SYS_BOARD if you like the name, or some
> custom defined CONFIG_BOARD_NAME like other boards do).
>
The board name in MX6-SabreSD. The Soc type (dual or quad core) is 
already printed by print_cpuinfo.
> Best regards,
>
> Wolfgang Denk
>
Best regards
Pierre Aubert