From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre AUBERT <p.aubert@staubli.com>
Date: Fri, 19 Apr 2013 10:23:44 +0200
Subject: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with
 i.MX6DL
In-Reply-To: <5170FD35.7050700@denx.de>
References: <1366296086-22394-1-git-send-email-p.aubert@staubli.com>
	<20130418173739.88D9A20019A@gemini.denx.de>
	<5170FD35.7050700@denx.de>
Message-ID: <5170FF10.5050608@staubli.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Le 19/04/2013 10:15, Stefano Babic a ?crit :
>
>>>   int checkboard(void)
>>>   {
>>> -	puts("Board: MX6Q-SabreSD\n");
>>> -
>>> +#ifdef CONFIG_MX6Q
>>> +    puts("Board: MX6Q-SabreSD\n");
>>> +#else
>>> +    puts("Board: MX6DL-SabreSD\n");
>>> +#endif
>> Can we please avoid such #ifdef's?  Here, we could for example refer
>> to the board name (CONFIG_SYS_BOARD if you like the name, or some
>> custom defined CONFIG_BOARD_NAME like other boards do).
> And who does set CONFIG_MX6Q ? You drop it, but I do not see who sets it.
It is set in boards.cfg:
> -mx6qsabresd                  arm         armv7       mx6qsabresd         freescale      mx6		mx6qsabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg
> +mx6qsabresd                  arm         armv7       mx6sabresd         freescale      mx6		mx6sabresd:IMX_CONFIG=board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg,MX6Q

>
> Best regards,
> Stefano Babic
>
Best regards
Pierre Aubert