[U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support

Bo Shen
2013-04-24T01:20:31Z

Hi Tom,

On 4/23/2013 23:34, Tom Rini wrote:
> On Tue, Apr 23, 2013 at 06:17:27PM +0800, Bo Shen wrote:
>
>> From: Roberto Cerati <roberto.cerati@bticino.it>
>>
>> The device interface is 16 bits wide.
>> All the available packets are read from the incoming fifo.
> [snip]
>> +/* union ks_tx_hdr - tx header data
>> + * @txb: The header as bytes
>
> /*
> * union ks_tx_hdr...

If I use this style comments, when use checkpatch.pl to check, it will
report:
--->8---
WARNING: networking block comments don't use an empty /* line, use /*
Comment...
#81: FILE: drivers/net/ks8851_mll.c:41:
+
+/*
---<8---

> Please fix globally.

So, do you think I should ignore the warning and fix this?

> [snip]
>> +#define RXFSHR_ERR (RXFSHR_RXCE | RXFSHR_RXRF |\
>
> #define<space> please, thanks.

I will fix it in next version.

>
> Looks fine aside from these style problems however, thanks!

Best Regards,
Bo Shen