[U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support

Tom Rini
2013-04-24T01:38:31Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/23/2013 09:20 PM, Bo Shen wrote:
> Hi Tom,
>
> On 4/23/2013 23:34, Tom Rini wrote:
>> On Tue, Apr 23, 2013 at 06:17:27PM +0800, Bo Shen wrote:
>>
>>> From: Roberto Cerati <roberto.cerati@bticino.it>
>>>
>>> The device interface is 16 bits wide. All the available packets
>>> are read from the incoming fifo.
>> [snip]
>>> +/* union ks_tx_hdr - tx header data + * @txb: The header as
>>> bytes
>>
>> /* * union ks_tx_hdr...
>
> If I use this style comments, when use checkpatch.pl to check, it
> will report: --->8--- WARNING: networking block comments don't use
> an empty /* line, use /* Comment... #81: FILE:
> drivers/net/ks8851_mll.c:41: + +/* ---<8---
>
>> Please fix globally.
>
> So, do you think I should ignore the warning and fix this?

Add a patch that adds:
- --ignore NETWORKING_BLOCK_COMMENT_STYLE

To .checkpatch.conf to the series first, as that should turn off that
check. Then correct as U-Boot uses the same style in all drivers.

Thanks again!

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRdzeWAAoJENk4IS6UOR1WA+gP/3tiJGaGdGXepBVzNr5xwrFW
0R7aBWx9buMKwyKCxFNlKz1fUfCwOfzS1nHQGN95fK3pvApI7XyYLcmUPN7+bx3p
CdgNVlaSHX5gqpl4+CHMKvF2QP4DjMT3jlUQPdTeYaaNCukMZDd3YRRpenazpWnL
igruu+NVghwgZxOQF7D9ubovizBdXzwHcV45R5iW2ZCkUAwr2PYnilOOt9hhizqB
bHScCXZ8rEWHttGpq+KeYVqWjhFyN/sgFcTuSyrBv56tXRgkUIrKfb6v/bUYI4Xz
8lx1AEBBsA6XVGupgPVLWXLwxYDLDS7vHklKrj68iAlqf7Rj2O2SYWbxHe6NL1vG
4sHJpExtieRcGAV632RmQTqduskOiJMYLxbvU+UVeTLyCV9CCFrae+c2E8oIYO2R
OSp1FrX5cdmXQWFY4SdoQ2NTWl/rUDOoUaTjLFBONMg8j9Z37JqZoO2GXohbv0El
Pl1BQmYfTRdrqa+MAF7ukxlOeDVLNzi0F2dOpB/R01Tn9qKfw+/lg5hFChp1E2je
f5hSqlLl932sPCUCuJzuwZbr1Ye77sJx88ns8V3dldrwYhG4VA5tLYFcioIXg81Y
SUzvmAjly92OXc34hXnrhK0Bny4evblHfaDVW+fhVADac4JhHKSoj8wbhWFyllkt
7QMgxq6ycR76u01Z1Q4e
=nsHB
-----END PGP SIGNATURE-----