[U-Boot] [RFC] Remove ^L string

[U-Boot] [RFC] Remove ^L string

[Bo Shen]

Remove ^L string

Signed-off-by: Bo Shen <voice.shen@gmail.com>
---
 common/cmd_bedbug.c |   19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/common/cmd_bedbug.c b/common/cmd_bedbug.c
index 77b6e3e..f2d7549 100644
--- a/common/cmd_bedbug.c
+++ b/common/cmd_bedbug.c
@@ -19,7 +19,6 @@ extern int run_command __P ((const char *, int));
 ulong dis_last_addr = 0;	/* Last address disassembled   */
 ulong dis_last_len = 20;	/* Default disassembler length */
 CPU_DEBUG_CTX bug_ctx;		/* Bedbug context structure    */
-\f
 
 /* ======================================================================
  * U-Boot's puts function does not append a newline, so the bedbug stuff
@@ -33,7 +32,6 @@ int bedbug_puts (const char *str)
 	printf ("%s\r\n", str);
 	return 0;
 }				/* bedbug_puts */
-\f
 
 
 /* ======================================================================
@@ -65,7 +63,6 @@ void bedbug_init (void)
 
 	return;
 }				/* bedbug_init */
-\f
 
 
 /* ======================================================================
@@ -106,7 +103,7 @@ int do_bedbug_dis (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 U_BOOT_CMD (ds, 3, 1, do_bedbug_dis,
 	    "disassemble memory",
 	    "ds <address> [# instructions]");
-\f
+
 /* ======================================================================
  * Entry point from the interpreter to the assembler.  Assembles
  * instructions in consecutive memory locations until a '.' (period) is
@@ -156,7 +153,7 @@ int do_bedbug_asm (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 
 U_BOOT_CMD (as, 2, 0, do_bedbug_asm,
 	    "assemble memory", "as <address>");
-\f
+
 /* ======================================================================
  * Used to set a break point from the interpreter.  Simply calls into the
  * CPU-specific break point set routine.
@@ -177,7 +174,7 @@ U_BOOT_CMD (break, 3, 0, do_bedbug_break,
 	    "break <address> - Break at an address\n"
 	    "break off <bp#> - Disable breakpoint.\n"
 	    "break show      - List breakpoints.");
-\f
+
 /* ======================================================================
  * Called from the debug interrupt routine.  Simply calls the CPU-specific
  * breakpoint handling routine.
@@ -192,7 +189,6 @@ void do_bedbug_breakpoint (struct pt_regs *regs)
 
 	return;
 }				/* do_bedbug_breakpoint */
-\f
 
 
 /* ======================================================================
@@ -250,7 +246,6 @@ void bedbug_main_loop (unsigned long addr, struct pt_regs *regs)
 
 	return;
 }				/* bedbug_main_loop */
-\f
 
 
 /* ======================================================================
@@ -274,7 +269,7 @@ int do_bedbug_continue (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv
 U_BOOT_CMD (continue, 1, 0, do_bedbug_continue,
 	    "continue from a breakpoint",
 	    "");
-\f
+
 /* ======================================================================
  * Interpreter command to continue to the next instruction, stepping into
  * subroutines.  Works by calling the find_next_addr() routine to compute
@@ -305,7 +300,7 @@ int do_bedbug_step (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 U_BOOT_CMD (step, 1, 1, do_bedbug_step,
 	    "single step execution.",
 	    "");
-\f
+
 /* ======================================================================
  * Interpreter command to continue to the next instruction, stepping over
  * subroutines.  Works by calling the find_next_addr() routine to compute
@@ -336,7 +331,7 @@ int do_bedbug_next (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 U_BOOT_CMD (next, 1, 1, do_bedbug_next,
 	    "single step execution, stepping over subroutines.",
 	    "");
-\f
+
 /* ======================================================================
  * Interpreter command to print the current stack.  This assumes an EABI
  * architecture, so it starts with GPR R1 and works back up the stack.
@@ -381,7 +376,7 @@ int do_bedbug_stack (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 U_BOOT_CMD (where, 1, 1, do_bedbug_stack,
 	    "Print the running stack.",
 	    "");
-\f
+
 /* ======================================================================
  * Interpreter command to dump the registers.  Calls the CPU-specific
  * show registers routine.
-- 
1.7.10.4

[U-Boot] [RFC] Remove ^L string

[Wolfgang Denk]

Dear Bo Shen,

In message <1366733517-6363-1-git-send-email-voice.shen@gmail.com> you wrote:
> Remove ^L string

What is the purpose of this modification?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am pleased to see that we have differences.  May we together become
greater than the sum of both of us.
	-- Surak of Vulcan, "The Savage Curtain", stardate 5906.4

[U-Boot] [RFC] Remove ^L string

[Tom Rini]

On Tue, Apr 23, 2013 at 08:09:50PM +0200, Wolfgang Denk wrote:

> Dear Bo Shen,
> 
> In message <1366733517-6363-1-git-send-email-voice.shen@gmail.com> you wrote:
> > Remove ^L string
> 
> What is the purpose of this modification?

Cleaning up the sources?  These are not intentionally inserted
characters we have in a handful of files.  Mainly in "bedbug" files and
malloc related files.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130423/b827cc5e/attachment.pgp>

[U-Boot] [RFC] Remove ^L string

[Wolfgang Denk]

Dear Tom,

In message <20130423185329.GK14952@bill-the-cat> you wrote:
> 
> > > Remove ^L string
> > 
> > What is the purpose of this modification?
>
> Cleaning up the sources?  These are not intentionally inserted
> characters we have in a handful of files.  Mainly in "bedbug" files and
> malloc related files.

I have to admit that I did not find the proginal source reference any
more, but my understanding is that this was imported code from another
project, and I see little reason to "fix" it (i. e. making it
incompatible to the original code) if there is not a good reason for
it.

Formfeed characters in the source code are IMHO mostly a matter of
taste - in the editor they don't really hurt, and who of you has been
printing the U-Boot source code in the last decade?

So my recommendation is to just ignore this.  Let's focus on real
problems, or at least real coding style violations.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HR Manager to job candidate "I see you've had no  computer  training.
Although  that  qualifies  you  for upper management, it means you're
under-qualified for our entry level positions."

[U-Boot] [RFC] Remove ^L string

[Bo Shen]

Hi Wolfgang,

On 4/24/2013 4:41, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20130423185329.GK14952@bill-the-cat> you wrote:
>>
>>>> Remove ^L string
>>>
>>> What is the purpose of this modification?
>>
>> Cleaning up the sources?  These are not intentionally inserted
>> characters we have in a handful of files.  Mainly in "bedbug" files and
>> malloc related files.
> I have to admit that I did not find the proginal source reference any
> more, but my understanding is that this was imported code from another
> project, and I see little reason to "fix" it (i. e. making it
> incompatible to the original code) if there is not a good reason for
> it.
>
> Formfeed characters in the source code are IMHO mostly a matter of
> taste - in the editor they don't really hurt, and who of you has been
> printing the U-Boot source code in the last decade?

To be honest, I have not test it, I just see the ^L string in source 
file with editor. And try to clean it.

> So my recommendation is to just ignore this.  Let's focus on real
> problems, or at least real coding style violations.

OK. We can ignore this, and let's focus on real problems.

Best Regards,
Bo Shen

> Best regards,
>
> Wolfgang Denk
>