From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Wed, 24 Apr 2013 09:43:08 +0800 Subject: [U-Boot] [RFC] Remove ^L string In-Reply-To: <20130423204102.1C08F384879@gemini.denx.de> References: <1366733517-6363-1-git-send-email-voice.shen@gmail.com> <20130423180951.03DB03811C5@gemini.denx.de> <20130423185329.GK14952@bill-the-cat> <20130423204102.1C08F384879@gemini.denx.de> Message-ID: <517738AC.7080700@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On 4/24/2013 4:41, Wolfgang Denk wrote: > Dear Tom, > > In message <20130423185329.GK14952@bill-the-cat> you wrote: >> >>>> Remove ^L string >>> >>> What is the purpose of this modification? >> >> Cleaning up the sources? These are not intentionally inserted >> characters we have in a handful of files. Mainly in "bedbug" files and >> malloc related files. > I have to admit that I did not find the proginal source reference any > more, but my understanding is that this was imported code from another > project, and I see little reason to "fix" it (i. e. making it > incompatible to the original code) if there is not a good reason for > it. > > Formfeed characters in the source code are IMHO mostly a matter of > taste - in the editor they don't really hurt, and who of you has been > printing the U-Boot source code in the last decade? To be honest, I have not test it, I just see the ^L string in source file with editor. And try to clean it. > So my recommendation is to just ignore this. Let's focus on real > problems, or at least real coding style violations. OK. We can ignore this, and let's focus on real problems. Best Regards, Bo Shen > Best regards, > > Wolfgang Denk >