From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] i2c, ppc4xx_i2c: switch to new multibus/multiadapter support
Date: Wed, 24 Apr 2013 14:48:09 +0200 [thread overview]
Message-ID: <5177D489.2020009@denx.de> (raw)
In-Reply-To: <1366803825-17093-1-git-send-email-dirk.eibach@gdsys.cc>
Hello Dirk,
On 24.04.2013 13:43, Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
> drivers/i2c/Makefile | 2 +-
> drivers/i2c/ppc4xx_i2c.c | 193 +++++++++++++++++++++++-----------------------
> 2 files changed, 97 insertions(+), 98 deletions(-)
Did you tried this patch with the mutlibus/multiadapter
framework?
When switching one i2c driver to this new Framework, you
must adapt all config files, which use this driver ...
Sorry, some stupid work, but it must be done, without
this I will bet, MAKEALL fails ...
[...]
> diff --git a/drivers/i2c/ppc4xx_i2c.c b/drivers/i2c/ppc4xx_i2c.c
> index 53fedd5..c924874 100644
> --- a/drivers/i2c/ppc4xx_i2c.c
> +++ b/drivers/i2c/ppc4xx_i2c.c
[...]
> +#ifdef CONFIG_SYS_I2C_PPC4XX_CH0
You introduce here new defines, please document them in
the README, thanks!
> +U_BOOT_I2C_ADAP_COMPLETE(ppc4xx_0, ppc4xx_i2c_init, ppc4xx_i2c_probe,
> + ppc4xx_i2c_read, ppc4xx_i2c_write,
> + ppc4xx_i2c_set_bus_speed,
> + CONFIG_SYS_I2C_PPC4XX_SPEED_0,
> + CONFIG_SYS_I2C_PPC4XX_SLAVE_0, 0)
> +#endif
> +#ifdef CONFIG_SYS_I2C_PPC4XX_CH1
> +U_BOOT_I2C_ADAP_COMPLETE(ppc4xx_1, ppc4xx_i2c_init, ppc4xx_i2c_probe,
> + ppc4xx_i2c_read, ppc4xx_i2c_write,
> + ppc4xx_i2c_set_bus_speed,
> + CONFIG_SYS_I2C_PPC4XX_SPEED_1,
> + CONFIG_SYS_I2C_PPC4XX_SLAVE_1, 1)
> +#endif
beside of this, your patch looks good ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-04-24 12:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 11:16 [U-Boot] [PATCH 0/11] Update gdsys ppc4xx-based boards Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 01/11] powerpc/ppc4xx: Add generic accessor functions for gdsys FPGA Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 02/11] powerpc/ppc4xx: Add gdsys mclink interface Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 03/11] powerpc/ppc4xx: Add fpgad command for dumping gdsys fpga registers Dirk Eibach
2013-04-22 17:14 ` Tom Rini
2013-04-23 9:53 ` [U-Boot] (WARNING!!! PGP with incorrect signature) " Eibach, Dirk
2013-04-23 11:40 ` Tom Rini
2013-04-22 11:16 ` [U-Boot] [PATCH 04/11] powerpc/ppc4xx: Add bitbang i2c interface for gdsys boards Dirk Eibach
2013-04-23 6:45 ` Stefan Roese
2013-04-23 6:16 ` Heiko Schocher
2013-04-23 7:35 ` [U-Boot] burst transaction test TigerLiu at viatech.com.cn
2013-04-23 12:16 ` Wolfgang Denk
2013-04-24 11:43 ` [U-Boot] [RFC] i2c, ppc4xx_i2c: switch to new multibus/multiadapter support Dirk Eibach
2013-04-24 12:48 ` Heiko Schocher [this message]
2013-04-24 13:00 ` Dirk Eibach
2013-04-24 13:04 ` Heiko Schocher
2013-04-24 13:11 ` Stefan Roese
2013-04-25 13:21 ` Dirk Eibach
2013-04-25 13:49 ` Heiko Schocher
2013-04-22 11:16 ` [U-Boot] [PATCH 05/11] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 06/11] powerpc/ppc4xx: Support gdsys multichannel iocon hardware Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 07/11] powerpc/ppc4xx: Use generic FPGA accessors on all gdsys 405ep/ex boards Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 08/11] powerpc/ppc4xx: Fixup phy erratum on gdsys iocon hardware Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 09/11] powerpc/ppc4xx: Increase timeout for gdsys mclink bus startup Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 10/11] powerpc/ppc4xx: Consider gdsys FPGA OSD size Dirk Eibach
2013-04-22 11:16 ` [U-Boot] [PATCH 11/11] powerpc/ppc4xx: Remove CONFIG_SYS_FLASH_PROTECTION from gdsys boards Dirk Eibach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5177D489.2020009@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox