From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 25 Apr 2013 14:31:19 +0200 Subject: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK In-Reply-To: <5178EB8B.7040600@denx.de> References: <1366559547-9063-1-git-send-email-marex@denx.de> <201304212112.31672.marex@denx.de> <1643889946.6492.1366573601954.JavaMail.root@advansee.com> <201304212229.03069.marex@denx.de> <51778C25.20501@denx.de> <1765510681.210959.1366801148967.JavaMail.root@advansee.com> <5178DBD9.1060109@denx.de> <5178EB8B.7040600@denx.de> Message-ID: <51792217.5000705@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 25/04/2013 10:38, Stefan Roese wrote: > Hi Stefano, > > On 25.04.2013 09:31, Stefano Babic wrote: >> On 24/04/2013 12:59, Beno?t Th?baudeau wrote: >> >>>> Apart of that and not related to this patch, if we in future use SPL >>>> also for booting from SD, we can get a single way to boot from different >>>> storage. TI based SOCs already do this: same SPL, it checks from SD and >>>> NAND. >>> >>> With this also comes the issue of BOOT_FROM in board/denx/m53evk/imximage.cfg. >>> Strictly speaking, in order to be correct, it should be #if-ed depending on some >>> config option: nand or sd. >> >> Right, this is also correct. Anyway, BOOT_FROM is used to get the offset >> inside the storage, and only to be as much flexible as possible, each >> storage has defined its own offset. However, Freescale uses the same >> offset (0x400) for most storages (NAND, SD..) and another one for NOR or >> OneNAND (0x1000). Maybe it is easier to have only this two cases. > > Yes, I would prefer that. > > And being at it, why don't we add the offset to the resulting image as > well? This would make programming the images to the destination (SD, > NAND, MMC etc) easier. Well, than this feature shoulb be added to the mkimage tool. I suggest to add a directive to the configuration file (imximage.cfg), such as PADDING or something like this. > We would not have to care for the correct offset > then (which is more error prone). And it is necessary btw, to have this > offset added, when using the FSL kobs-ng tool To my knowledge: do you have the sources for this tool to better understand what it does ? I can find binaries with different version (I think 1.3 is the last), but no sources at all. I have not found if it is open source or not. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================