From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/16] i2c, ppc4xx_i2c: switch to new multibus/multiadapter support
Date: Mon, 29 Apr 2013 16:14:33 +0200 [thread overview]
Message-ID: <517E8049.2010206@denx.de> (raw)
In-Reply-To: <1366893601-21802-1-git-send-email-dirk.eibach@gdsys.cc>
Hello Dirk,
On 25.04.2013 14:40, Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
> This patch is based on http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/20130416_multibus_v2.
> Heiko said:
> "... and if the merge window opens
> I post this patch with the other patches for this new
> i2c framework on the ML."
> So, Heiko, the merge window is wide open, your turn now :)
;-) I try to do this this week ...
Thanks for your work, patch seems good to me, just one nitpicking:
[hs at pollux u-boot]$ ./tools/checkpatch.pl mbox
WARNING: Avoid CamelCase: <get_OPB_freq>
#1264: FILE: drivers/i2c/ppc4xx_i2c.c:128:
+ divisor = (get_OPB_freq() - 1) / 10000000;
total: 0 errors, 1 warnings, 0 checks, 1662 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE USLEEP_RANGE
mbox has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[hs at pollux u-boot]$
This should be fixed too, but this is not only i2c specific ... so I
accept your patch and add it to my multibus branch, make some further
tests, and then post it again in the patchserie, ok?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2013-04-29 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 12:40 [U-Boot] [PATCH 01/16] i2c, ppc4xx_i2c: switch to new multibus/multiadapter support Dirk Eibach
2013-04-29 14:14 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E8049.2010206@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox