From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 30 Apr 2013 15:05:53 +0200 Subject: [U-Boot] [PATCH 4/6] imx: mx35pdk: Convert to iomux-v3 In-Reply-To: <1110859211.411663.1367267988706.JavaMail.root@advansee.com> References: <1367268080-1403-1-git-send-email-benoit.thebaudeau@advansee.com> <1367268080-1403-4-git-send-email-benoit.thebaudeau@advansee.com> <1110859211.411663.1367267988706.JavaMail.root@advansee.com> Message-ID: <517FC1B1.2040106@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 29/04/2013 22:39, Beno?t Th?baudeau wrote: > Hi Stefano, > Hi Beno?t, > On Monday, April 29, 2013 10:41:18 PM, Beno?t Th?baudeau wrote: >> There is no change of behavior. >> >> Signed-off-by: Beno?t Th?baudeau >> --- > [...] >> diff --git a/board/freescale/mx35pdk/mx35pdk.c >> b/board/freescale/mx35pdk/mx35pdk.c >> index 9993d7b..12e84d7 100644 >> --- a/board/freescale/mx35pdk/mx35pdk.c >> +++ b/board/freescale/mx35pdk/mx35pdk.c > [...] >> @@ -271,8 +243,7 @@ int board_late_init(void) >> pmic_reg_read(p, REG_MODE_0, &pmic_val); >> pmic_reg_write(p, REG_MODE_0, pmic_val | VGEN3EN); >> >> - mxc_request_iomux(MX35_PIN_COMPARE, MUX_CONFIG_GPIO); >> - mxc_iomux_set_input(MUX_IN_GPIO1_IN_5, INPUT_CTL_PATH0); >> + imx_iomux_v3_setup_pad(MX35_PAD_COMPARE__GPIO1_5); >> >> gpio_direction_output(IMX_GPIO_NR(2, 5), 1); > ^ > Note that GPIO2[5] seems to be used instead of GPIO1[5] above. I have not > checked if this is a bug or not. I let you check that as the board maintainer. Good catch, in fact it is a bug ! According to schematics, GPIO1[5] should be set to 1 (it drives a multiplexer), and not GPIO2[5]. I will fix it later with another patch after yours flow into mainline. Thanks, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================