public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow U-Boot scripts to be placed in a .env file
Date: Mon, 06 May 2013 08:02:47 -0500	[thread overview]
Message-ID: <5187A9F7.6050007@gmail.com> (raw)
In-Reply-To: <20130417054435.3E4612001AD@gemini.denx.de>

On 04/17/2013 12:44 AM, Wolfgang Denk wrote:
> Dear Simon Glass,
> 
> In message <1366155414-6525-1-git-send-email-sjg@chromium.org> you wrote:
>> At present U-Boot environment variables, and thus scripts, are defined
>> by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text
>> to this file and dealing with quoting and newlines is harder than it
>> should be. It would be better if we could just type the script into a
>> text file and have it included by U-Boot.
>>
>> Add a feature that brings in a .env file associated with the board
>> config, if present. To use it, create a file in include/configs
>> with the same name as you could board config file, except with a
>> .env extension instead of a .h extension. The variables should be
>> separated by \0. Comments are permitted, using # as the first character
>> in a line.
> 
> Please do not litter the include/configs/ directory with such stuff.
> It's more than big enough already.  Please put such files into the
> respective board directories.
> 
> And if you do something like this, then please go the way to the end.
> Forget about the \0 termination, make it a plain text file instead,
> something that can be used with "env import -t" as well (or created
> with "env export -t").

What about allowing a binary created with mkenvimage to be built-in.
This would give us a standard build rule to build a separate env binary
as well.

Rob

  parent reply	other threads:[~2013-05-06 13:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 23:36 [U-Boot] [PATCH] Allow U-Boot scripts to be placed in a .env file Simon Glass
2013-04-17  5:44 ` Wolfgang Denk
2013-04-17 22:26   ` Otavio Salvador
2013-04-23 21:32   ` Simon Glass
2013-04-23 23:33     ` Tom Rini
2013-04-24  0:29       ` Simon Glass
2013-04-24  2:14         ` Otavio Salvador
2013-04-24  2:36           ` Simon Glass
2013-04-24  2:44             ` Otavio Salvador
2013-04-24  3:05               ` Simon Glass
2013-04-24  3:20                 ` Otavio Salvador
2013-04-24  3:43                   ` Simon Glass
2013-04-24  5:36                   ` Wolfgang Denk
2013-04-26  8:34                     ` Smithlife
2013-04-24  5:34                 ` Wolfgang Denk
2013-05-06 13:02   ` Rob Herring [this message]
2013-05-06 13:14     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5187A9F7.6050007@gmail.com \
    --to=robherring2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox