From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 07 May 2013 15:12:39 +0200 Subject: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37ACAFEF3F@HQMAIL04.nvidia.com> References: <1367668903-29653-1-git-send-email-hs@denx.de> <1367668903-29653-9-git-send-email-hs@denx.de> <5187FFAF.6000802@wwwdotorg.org> <5FBF8E85CA34454794F0F7ECBA79798F37ACAFEF3F@HQMAIL04.nvidia.com> Message-ID: <5188FDC7.906@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Am 06.05.2013 21:39, schrieb Tom Warren: > Thanks, Stephen. Adding Yen, who wrote the original Tegra I2C driver. > >> -----Original Message----- >> From: Stephen Warren [mailto:swarren at wwwdotorg.org] >> Sent: Monday, May 06, 2013 12:09 PM >> To: Heiko Schocher >> Cc: u-boot at lists.denx.de; Tom Warren >> Subject: Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C >> framework >> >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: >>> From: Simon Glass >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the >>> Tegra i2c driver to support this. >> >>> include/configs/beaver.h | 5 ++- >>> include/configs/cardhu.h | 3 +- >>> include/configs/dalmore.h | 3 +- >>> include/configs/seaboard.h | 5 ++- >>> include/configs/trimslice.h | 5 ++- >>> include/configs/whistler.h | 5 ++- >> >> There are a lot more Tegra boards than just those. Shouldn't they all be >> updated? You also didn't Cc the Tegra maintainer - I have done on this mail. > > Heiko - please explain what the new CONFIG_SYS_I2C_TEGRA switch does, what it adds to/improves upon for the extant Tegra I2C driver, and what testing you did. It just convert the existing i2c driver to the new i2c multibus/ multiadapter framework, see the description in the README for this new define. I add Simon Glass to this, as he did this patch for the tegra i2c driver. I did only compile tests ... IIRC Simon did some tests on real HW. > The boards listed are the only ones w/CONFIG_TEGRA_I2C currently enabled, so I don't think any others need it, until such time as their maintainers need to add I2C support. Yes, I think so too, as I get no compilerwarning/error when doing a "MAKEALL arm" ... bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany