public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2, batch 2 17/23] powerpc/85xx: add missing QMAN frequency calculation
Date: Tue, 7 May 2013 16:18:21 -0700	[thread overview]
Message-ID: <51898BBD.5010906@freescale.com> (raw)
In-Reply-To: <CAKWjMd5t4rE=rvxiETDQ-4deBRt-sc1Mf1wXPh8t_KmL0D2Log@mail.gmail.com>

On 05/07/2013 04:04 PM, Andy Fleming wrote:
> 
> 
> 
> On Mon, Mar 25, 2013 at 12:33 PM, York Sun <yorksun@freescale.com
> <mailto:yorksun@freescale.com>> wrote:
> 
>     From: Shaohui Xie <Shaohui.Xie@freescale.com
>     <mailto:Shaohui.Xie@freescale.com>>
> 
>     When CONFIG_SYS_FSL_QORIQ_CHASSIS2 is not defined, QMAN frequency
>     will not
>     be initialized, and QMAN will have a wrong frequency display.
> 
>     Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com
>     <mailto:Shaohui.Xie@freescale.com>>
>     ---
>      arch/powerpc/cpu/mpc85xx/speed.c |    4 ++++
>      1 file changed, 4 insertions(+)
> 
>     diff --git a/arch/powerpc/cpu/mpc85xx/speed.c
>     b/arch/powerpc/cpu/mpc85xx/speed.c
>     index 9fc7b54..f00b1ab 100644
>     --- a/arch/powerpc/cpu/mpc85xx/speed.c
>     +++ b/arch/powerpc/cpu/mpc85xx/speed.c
>     @@ -293,6 +293,10 @@ void get_sys_info (sys_info_t * sysInfo)
>      #endif
>      #endif
> 
>     +#ifdef CONFIG_SYS_DPAA_QBMAN
>     +       sysInfo->freqQMAN = sysInfo->freqSystemBus / 2;
>     +#endif
>     +
> 
> 
> 
> Can we just move the original copy of the above lines out of the #ifdef?
> I don't see any reason to do it the same way in two places.
> 
>
You mean delete #ifdef? It will have a compiling error, won't it? See
include/e500.h, the freqQMAN is withing #ifdef.

York

  reply	other threads:[~2013-05-07 23:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 17:33 [U-Boot] [Patch v2, batch 2 01/23] powerpc/B4860: Corrected FMAN1 operating frequency print at u-boot York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 02/23] powerpc/mpc85xx: Add definitions for HDBCR registers York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 03/23] powerpc/pcie: add PCIe version 3.x support York Sun
2013-05-13 18:50   ` Andy Fleming
2013-05-13 19:25     ` York Sun
2013-05-13 22:49       ` Andy Fleming
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 04/23] powerpc/mpc85xx: Update corenet global utility block registers York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 05/23] powerpc/t4240qds: Fix SPI flash type York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 06/23] e6500: Move L1 enablement after L2 enablement York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 07/23] T4/serdes: fix the serdes clock frequency display York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 08/23] powerpc/t4240qds: fix XAUI card PHY address York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 09/23] Fman/t4240: some fix for 10G XAUI York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 10/23] T4/SerDes: correct the SATA index York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 11/23] powerpc/t4240qds: Update DDR timing table York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 12/23] powerpc/mpc8xxx: Fix DDR 3-way interleaving York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 13/23] powerpc/mpc85xx: Fix portal setup York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 14/23] powerpc/t4240qds: Add voltage ID support York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 15/23] T4/USB: Add USB 2.0 UTMI dual phy support York Sun
2013-05-09  0:17   ` Andy Fleming
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 16/23] T4/serdes: fix the actual serdes clock frequency York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 17/23] powerpc/85xx: add missing QMAN frequency calculation York Sun
2013-05-07 23:04   ` Andy Fleming
2013-05-07 23:18     ` York Sun [this message]
2013-05-09  0:40       ` Fleming Andy-AFLEMING
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 18/23] powerpc/corenet2: Print SerDes protocol in decimal York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 19/23] powerpc/mpc85xx: Fix PIR parsing for chassis2 York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 20/23] powerpc/t4240: Fix SerDes protocol arrays with const prefix York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 21/23] powerpc/mpc85xx: Add T4160 SoC York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 22/23] powerpc/t4240qds: Move SoC define into boards.cfg York Sun
2013-03-25 17:33 ` [U-Boot] [Patch v2, batch 2 23/23] powerpc: Add T4160QDS York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51898BBD.5010906@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox