From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] avr32: fix relocation address calculation
Date: Fri, 10 May 2013 12:57:21 +0200 [thread overview]
Message-ID: <518CD291.703@gmail.com> (raw)
In-Reply-To: <20130510112444.4dca773f@lilith>
Hi Albert,
On 05/10/2013 11:24 AM, Albert ARIBAUD wrote:
> Hi Andreas,
>
> On Wed, 8 May 2013 11:25:17 +0200, Andreas Bie?mann
> <andreas.devel@googlemail.com> wrote:
>
>> Commit 1865286466a5d0c7f2e3c37632da56556c838e9e (Introduce generic link
>> section.h symbol files) changed the __bss_end symbol type from char[] to
>> ulong. This led to wrong relocation parameters which ended up in a not working
>> u-boot. Unfortunately this is not clear to see cause due to RAM aliasing we
>> may get a 'half-working' u-boot then.
>>
>> Fix this by dereferencing the __bss_end symbol where needed.
>
> (cc:ing Simon and Tom)
>
> The dereferencing is correct, so this patch seems good per se (it could
> actually have applied when __bss_end was still a char[]).
well, as I understood this the __bss_end being a char[] did implicitly
take the address when accessing __bss_end (as we do when we have a
definition of char foo[2] and we take just 'foo'). But you say here we
should reference the address of __bss_end while it was still of type
char[]. Sorry, I do not understand that, can you please clarify?
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-05-10 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 9:25 [U-Boot] [PATCH] avr32: fix relocation address calculation Andreas Bießmann
2013-05-10 9:24 ` Albert ARIBAUD
2013-05-10 10:57 ` Andreas Bießmann [this message]
2013-05-10 15:09 ` Albert ARIBAUD
2013-05-10 17:02 ` Michael Cashwell
2013-05-10 17:15 ` Albert ARIBAUD
2013-05-13 8:35 ` Andreas Bießmann
2013-05-13 11:34 ` Albert ARIBAUD
2013-05-13 11:43 ` Albert ARIBAUD
2013-05-13 8:38 ` [U-Boot] " Andreas Bießmann
2013-05-13 8:42 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518CD291.703@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox