From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Mon, 13 May 2013 14:30:23 +0800 Subject: [U-Boot] [Patch v2 1/4] USB: ohci-at91: support sama5d3x devices In-Reply-To: <518F7CD0.8090701@googlemail.com> References: <1363068932-2485-1-git-send-email-voice.shen@atmel.com> <1363068932-2485-2-git-send-email-voice.shen@atmel.com> <518F7CD0.8090701@googlemail.com> Message-ID: <5190887F.3070800@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andreas, On 5/12/2013 19:28, Andreas Bie?mann wrote: > Dear Bo Shen, > > On 12.03.2013 07:15, Bo Shen wrote: >> Add OHCI support for sama5d3x devices > > can you please rebase this patch and send again? OK, I will do it at next version. >> >> Signed-off-by: Bo Shen >> --- >> change in v2: >> - change #if defined to #ifdef for sama5d3 >> --- >> drivers/usb/host/ohci-at91.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c >> index efd711d..086cd0f 100644 >> --- a/drivers/usb/host/ohci-at91.c >> +++ b/drivers/usb/host/ohci-at91.c >> @@ -42,7 +42,7 @@ int usb_cpu_init(void) >> while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB) >> ; >> #elif defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) >> || \ >> - defined(CONFIG_AT91SAM9X5) >> + defined(CONFIG_AT91SAM9X5) || defined(CONFIG_SAMA5D3) >> /* Enable UPLL */ >> writel(readl(&pmc->uckr) | AT91_PMC_UPLLEN | AT91_PMC_BIASEN, >> &pmc->uckr); >> @@ -54,7 +54,12 @@ int usb_cpu_init(void) >> #endif >> >> /* Enable USB host clock. */ >> +#ifdef CONFIG_SAMA5D3 >> + writel(1 << (ATMEL_ID_UHP - 32), &pmc->pcer1); > > Please reorder the patches so that pmc->pcer1 is declared before used. Ok, thanks for figure out this. I will do it at next version. > Best regards > > Andreas Bie?mann Best Regards, Bo Shen