* [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error
@ 2013-05-13 6:14 Bo Shen
2013-05-14 18:16 ` Michael Heimpold
0 siblings, 1 reply; 3+ messages in thread
From: Bo Shen @ 2013-05-13 6:14 UTC (permalink / raw)
To: u-boot
The commit d196bd8 (env_mmc: add support for redundant environment)
introduce the following compile error when enable reduandant
environment support with MMC
---8<---
env_mmc.c:149: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:248: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:250: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:252: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:254: error: 'env_t' has no member named 'flags'
env_mmc.c:267: error: 'env_t' has no member named 'flags'
make[1]: *** [env_mmc.o] Error 1
--->8---
Add this patch to fix it
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
include/environment.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/environment.h b/include/environment.h
index 4c6a37b..460ccb4 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -75,6 +75,12 @@
# endif
#endif /* CONFIG_ENV_IS_IN_FLASH */
+#if defined(CONFIG_ENV_IS_IN_MMC)
+# ifdef CONFIG_ENV_OFFSET_REDUND
+# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
+# endif
+#endif
+
#if defined(CONFIG_ENV_IS_IN_NAND)
# if defined(CONFIG_ENV_OFFSET_OOB)
# ifdef CONFIG_ENV_OFFSET_REDUND
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error
2013-05-13 6:14 [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error Bo Shen
@ 2013-05-14 18:16 ` Michael Heimpold
2013-05-15 1:14 ` Bo Shen
0 siblings, 1 reply; 3+ messages in thread
From: Michael Heimpold @ 2013-05-14 18:16 UTC (permalink / raw)
To: u-boot
Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:
> The commit d196bd8 (env_mmc: add support for redundant environment)
> introduce the following compile error when enable reduandant
> environment support with MMC
> ---8<---
> env_mmc.c:149: error: 'env_t' has no member named 'flags'
> env_mmc.c:248: error: 'env_t' has no member named 'flags'
> env_mmc.c:248: error: 'env_t' has no member named 'flags'
> env_mmc.c:250: error: 'env_t' has no member named 'flags'
> env_mmc.c:250: error: 'env_t' has no member named 'flags'
> env_mmc.c:252: error: 'env_t' has no member named 'flags'
> env_mmc.c:252: error: 'env_t' has no member named 'flags'
> env_mmc.c:254: error: 'env_t' has no member named 'flags'
> env_mmc.c:254: error: 'env_t' has no member named 'flags'
> env_mmc.c:267: error: 'env_t' has no member named 'flags'
> make[1]: *** [env_mmc.o] Error 1
> --->8---
>
> Add this patch to fix it
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> include/environment.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/environment.h b/include/environment.h
> index 4c6a37b..460ccb4 100644
> --- a/include/environment.h
> +++ b/include/environment.h
> @@ -75,6 +75,12 @@
> # endif
> #endif /* CONFIG_ENV_IS_IN_FLASH */
>
> +#if defined(CONFIG_ENV_IS_IN_MMC)
> +# ifdef CONFIG_ENV_OFFSET_REDUND
> +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> +# endif
> +#endif
> +
> #if defined(CONFIG_ENV_IS_IN_NAND)
> # if defined(CONFIG_ENV_OFFSET_OOB)
> # ifdef CONFIG_ENV_OFFSET_REDUND
>
s/reduandant/redundant/
Reviewed-by: Michael Heimpold <mhei@heimpold.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error
2013-05-14 18:16 ` Michael Heimpold
@ 2013-05-15 1:14 ` Bo Shen
0 siblings, 0 replies; 3+ messages in thread
From: Bo Shen @ 2013-05-15 1:14 UTC (permalink / raw)
To: u-boot
Hi Michael,
On 5/15/2013 02:16, Michael Heimpold wrote:
> Am Montag, 13. Mai 2013, 14:14:46 schrieben Sie:
>> The commit d196bd8 (env_mmc: add support for redundant environment)
>> introduce the following compile error when enable reduandant
>> environment support with MMC
>> ---8<---
>> env_mmc.c:149: error: 'env_t' has no member named 'flags'
>> env_mmc.c:248: error: 'env_t' has no member named 'flags'
>> env_mmc.c:248: error: 'env_t' has no member named 'flags'
>> env_mmc.c:250: error: 'env_t' has no member named 'flags'
>> env_mmc.c:250: error: 'env_t' has no member named 'flags'
>> env_mmc.c:252: error: 'env_t' has no member named 'flags'
>> env_mmc.c:252: error: 'env_t' has no member named 'flags'
>> env_mmc.c:254: error: 'env_t' has no member named 'flags'
>> env_mmc.c:254: error: 'env_t' has no member named 'flags'
>> env_mmc.c:267: error: 'env_t' has no member named 'flags'
>> make[1]: *** [env_mmc.o] Error 1
>> --->8---
>>
>> Add this patch to fix it
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> include/environment.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/include/environment.h b/include/environment.h
>> index 4c6a37b..460ccb4 100644
>> --- a/include/environment.h
>> +++ b/include/environment.h
>> @@ -75,6 +75,12 @@
>> # endif
>> #endif /* CONFIG_ENV_IS_IN_FLASH */
>>
>> +#if defined(CONFIG_ENV_IS_IN_MMC)
>> +# ifdef CONFIG_ENV_OFFSET_REDUND
>> +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>> +# endif
>> +#endif
>> +
>> #if defined(CONFIG_ENV_IS_IN_NAND)
>> # if defined(CONFIG_ENV_OFFSET_OOB)
>> # ifdef CONFIG_ENV_OFFSET_REDUND
>>
>
> s/reduandant/redundant/
Thanks for figure out this, I will correct it in next version.
> Reviewed-by: Michael Heimpold <mhei@heimpold.de>
In next version, I will add your Reviewed-by tag.
Best Regards,
Bo Shen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-15 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-13 6:14 [U-Boot] [PATCH] mmc: fix env in mmc with redundant compile error Bo Shen
2013-05-14 18:16 ` Michael Heimpold
2013-05-15 1:14 ` Bo Shen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox