From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 15 May 2013 15:20:17 +0200 Subject: [U-Boot] [PATCH v2 1/6] arm: mvf600: Add Vybrid MVF600 CPU support In-Reply-To: <20130515143957.16e6bebc@lilith> References: <1368525108-2266-1-git-send-email-b18965@freescale.com> <1368525108-2266-2-git-send-email-b18965@freescale.com> <519343B0.5000105@denx.de> <20130515140929.39193f48@lilith> <51937E81.7090606@denx.de> <20130515143957.16e6bebc@lilith> Message-ID: <51938B91.5020909@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15/05/2013 14:39, Albert ARIBAUD wrote: > Hi Stefano, > Hi Albert, hi Alison, >> Agree. I think adding armv{4,5,6,7...} is the most clean solution. > > This is a clean solution, but do we have the problem? IOW, do we have a > substantial quantity of code that is common to a given ISA but neither > generic to ARM (if it were, it would go to arch/arm or arch/arm/lib) nor > specific to a CPU (if it were, then it should stay under arch/arm/cpu/)? > If we do then moving this code under an isa tree makes sense; if we > don't, then arch/arm/cpu// is enough, and mvf600 just jas to > move under arch/arm/cpu/ and copy the few ARMv5 snippets it needs from > another ARMv5-based cpu. Roght - this is also a clean solution, because we have already arm926 and so on. Alison, please check how you can move your initialization code as Alber suggested. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================