From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 15 May 2013 08:32:32 -0600
Subject: [U-Boot] [PATCH] ARM: arm720t: Add missing
 CONFIG_SKIP_LOWLEVEL_INIT guard for cpu_init_crit
In-Reply-To: <1368587097.8322.2.camel@phoenix>
References: <1368587097.8322.2.camel@phoenix>
Message-ID: <51939C80.3000205@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/14/2013 09:04 PM, Axel Lin wrote:
> cpu_init_crit() can be skipped, but the code is still enabled requiring a
> platform to supply lowlevel_init().

> diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S

> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT
>  cpu_init_crit:
>  
>  #if !defined(CONFIG_TEGRA)
> @@ -258,6 +259,7 @@ cpu_init_crit:
>  #endif
>  
>  	mov	pc, lr
> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that
Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the
Tegra-specific ifdef from the body of that function. That's assuming
that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects.