public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lubomir Popov <lpopov@mm-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] OMAP5: uEVM: Enable USB EHCI functionality (preliminary, not tested)
Date: Thu, 16 May 2013 11:23:00 +0300	[thread overview]
Message-ID: <51949764.1050100@mm-sol.com> (raw)
In-Reply-To: <20130515220602.GA32163@bill-the-cat>

Hi Tom,

Thanks for testing. One more thing needs fixing, my fault.
I forgot that the mux_data.h file comes from the sEVM w/o
any modification. Not only USB shall not work...

Fix is in http://patchwork.ozlabs.org/patch/244233/

Please see comments inline below.

On 16/05/13 01:06, Tom Rini wrote:
> On Wed, May 15, 2013 at 06:55:24PM +0300, Lubomir Popov wrote:
> 
>> Prerequisites: appropriate patches to the USB EHCI and Eth
>> drivers, and to the OMAP5 clock register definitions. 
>>
>> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
>> ---
>> Assumption is that this code shall run on TI 750-2628-21X
>> hardware (also known as OMAP5432 ES2.0 PandaBoard5) - the
>> GPIOs that I used used for HSIC reset correspond to that
>> board. Looking at mux_data.h however, I'm somewhat concerned.
>> All the uevm board files are inherited from the sEVM, which
>> is a very different hardware platform, and I'm afraid that
>> only changing the file names might not be sufficient.
>>
>> The patch is not tested yet due to lack of hardware. Tom,
>> I'm hoping for your assistance.
> 
> OK, I applied:
> $ git log --oneline master..
> 93460ef OMAP4/5: Add USB EHCI support
> d18c49c OMAP5: Enable USB Ethernet support with LAN9730
> 15a4481 OMAP5: Enable access to auxclk registers
> f307fc2 OMAP5: Power: Add more functionality to Palmas driver
> efdf00c OMAP5: uEVM: Enable USB EHCI functionality (preliminary, not tested)
> And added:
> +#define CONFIG_USB_ULPI
> +#define CONFIG_USB_ULPI_VIEWPORT_OMAP
> to include/configs/omap5_uevm.h
Actually not needed at all for this board - it does not have any
ULPI PHYs. We shall just get dead code.
> 
> And usb start/usb rescan don't see any devices.
> OMAP5432 uEVM # usb start
> (Re)start USB...
> USB0:   USB EHCI 1.00
> scanning bus 0 for devices... 1 USB Device(s) found
>        scanning usb for storage devices... 0 Storage Device(s) found
>        scanning usb for ethernet devices... 0 Ethernet Device(s) found
> 
> Cable was plugged into the eth and a storage device was also plugged in.
> I suspect that we need to set CONFIG_OMAP_EHCI_PHY1_RESET_GPIO /
> CONFIG_OMAP_EHCI_PHY2_RESET_GPIO.  I'm looking around for the schematic
> so I can try and find that out.
No. This is for ULPI PHY reset only, we are using CONFIG_OMAP_HSIC_PORT2_RESET_GPIO
and CONFIG_OMAP_HSIC_PORT3_RESET_GPIO for the HSIC devices. The problem is that
these pads were not configured to GPIO mode. Above patch fixes this.
> 
Best regards,
Lubo

  parent reply	other threads:[~2013-05-16  8:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 15:55 [U-Boot] [PATCH RFC] OMAP5: uEVM: Enable USB EHCI functionality (preliminary, not tested) Lubomir Popov
2013-05-15 16:09 ` Nishanth Menon
2013-05-15 22:06 ` Tom Rini
2013-05-15 22:33   ` Gilles Chanteperdrix
2013-05-16  8:23   ` Lubomir Popov [this message]
2013-05-16 12:28     ` Tom Rini
2013-05-16 14:56       ` Lubomir Popov
2013-05-16 15:29         ` Tom Rini
2013-05-16 18:43           ` Lubomir Popov
2013-05-17 13:52             ` Tom Rini
2013-05-17  5:34           ` Sricharan R
2013-05-17  9:35             ` Lubomir Popov
2013-05-15 22:31 ` Gilles Chanteperdrix
2013-05-16  8:39   ` Lubomir Popov
2013-05-18 15:25     ` Gilles Chanteperdrix
2013-05-18 17:07       ` Tom Rini
2013-05-18 17:12         ` Gilles Chanteperdrix
2013-05-18 19:13       ` Lubomir Popov
2013-05-18 19:16         ` Gilles Chanteperdrix
2013-05-18 19:24           ` Lubomir Popov
2013-05-18 20:46         ` Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51949764.1050100@mm-sol.com \
    --to=lpopov@mm-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox