public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] ulpi patch in uboot
Date: Thu, 16 May 2013 12:34:39 +0200	[thread overview]
Message-ID: <5194B63F.2040205@denx.de> (raw)
In-Reply-To: <5194AA1B.40201@amarulasolutions.com>

On 16/05/2013 11:42, Michael Trimarchi wrote:
> Hi a;;,
> 

Hi Michael,

(I posted also to u-boot ML to check if someone else had issues)

> I think that this patch could be wrong for omap4 and omap3. The opcode shift
> shuld be 22 and not 21. And are you sure that are you using the bit 31
> in the correct way?
> 
> Stefano, are you sure about your testing?

Well, it happened more as one year ago, but I tested again this morning
with the AM3517 I used for testing, using a version 2013.04-rc1

twister => usb start
(Re)start USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 3 USB Device(s) found
       scanning usb for storage devices... 1 Storage Device(s) found
twister => fatls usb 0
            .disk/

So it seems working - I have not yet checked in manual, but if the shift
is wrong, it seems it has no drawbacks on my board ;-(

Best regards,
Stefano

> 
> Michael
> 
> commit 928c4bdf9b069be218436d25b96721395c4d671f
> Author: Govindraj.R <govindraj.raja@ti.com>
> Date:   Mon Feb 6 03:55:32 2012 +0000
> 
>     usb: ulpi: Add omap-ulpi-view port support
>     
>     Based on discussion from this thread [1].
>     Adding omap-view port that helps us in using the generic ulpi
>     framework for any ulpi phy ops using the INSNREG05_ULPI viewport
>     reg available on omap platform.
>     
>     Currently ehci ports are available on omap3/4 platforms so enable the same
>     for beagle and panda, patch is tested on the same boards.
>     
>     Thanks to Igor Grinberg <grinberg@compulab.co.il> for reviewing the
>     omap-ehci patches and suggesting this approach.
>     
>     [1]: http://www.mail-archive.com/u-boot at lists.denx.de/msg76076.html
> 
> 


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

       reply	other threads:[~2013-05-16 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5194AA1B.40201@amarulasolutions.com>
2013-05-16 10:34 ` Stefano Babic [this message]
2013-05-16 11:17   ` [U-Boot] ulpi patch in uboot Michael Trimarchi
2013-05-16 13:19   ` Michael Trimarchi
2013-05-16 14:24     ` Igor Grinberg
2013-05-16 14:35     ` Stefano Babic
2013-05-16 15:00       ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5194B63F.2040205@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox