From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sat, 18 May 2013 14:25:42 -0400 Subject: [U-Boot] [PATCH 1/2] SPL: Makefile: Build a separate autoconf.mk for SPL In-Reply-To: References: <1367941975-2213-1-git-send-email-joelagnel@ti.com> <20130517210352.GX32163@bill-the-cat> Message-ID: <5197C7A6.4020502@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/18/2013 02:22 PM, Joel A Fernandes wrote: > Hi Tom, Sorry for the delay as I've been traveling. > > On Friday, May 17, 2013, Tom Rini wrote: > > On Tue, May 07, 2013 at 10:52:54AM -0500, Joel A Fernandes wrote: > >> SPL defines CONFIG_SPL_BUILD but this does not percolate to the >> autoconf.mk Makefile. As a result the >> build > breaks when >> CONFIG_SPL_BUILD is used in the board-specific include header >> file. With this, there is a possibility of having a CONFIG >> option defined in the header file but not defined in the >> Makefile causing all kinds of build failure and problems. >> >> It also messes things for up, for example, when one might want to >> undefine options to keep the SPL small and doesn't want to be >> stuck with the CONFIG options used for U-boot. Lastly, this >> also avoids defining special CONFIG_SPL_ variables for cases >> where some options are required in U-boot but not in SPL. >> >> We add a spl-autoconf.mk rule that is > generated for SPL with the >> CONFIG_SPL_BUILD flag and conditionally include it for SPL >> builds. > > This breaks tegra boards such as ventura and a number of others > currently, please fix. Thanks! > > > I don't have a tegra. Is this a build or runtime issue? If its > build , I'll try building some of those targets and let you know. > Might be 1 to 2 more days once I get back today. It's build time. Once you've fixed one, please make sure that MAKEALL - -a arm completes without error. Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRl8emAAoJENk4IS6UOR1WT4YP/Rh7H943DZgZuZW4hJopHCC0 JOB5yzeehgBl0805IIZN+yAhU/goQ8iXDKi+JrulySltcL31JrHArG1Hik9gyR0Q 0R+37OedqeeoJLhBQi3+5W55wdtkV2c50JF1uoqbzbOKaozoasR0gLsU5Em36Ndy LjXcq6JvhRp0jXoM+NNTKtsxp4CWGx5jms8FVVePy9ScT3QLEVC1GNW7yrq3JhDY Cyu9Z1EXC4+vafX9PSaneTtXaaC48gpIw8TJ0vIsp8oiroypECatDpH2CigF8qZw ugN9WqFVZi+uWT9NGOhUaWXYUWYYI7vDz7WG0NqliMbKkJOxl6LgHU/OjYTZCfeR pilsjH8RDQMnDvbXdCfXTXMfvFGy507K/rjmFoGZcasJ13CXRg44halE7ZsafCsb dzcuI51a/y4YHD7MOdi1EWKQQSjVulTUw0rxL88GYCWXrOGYsxmvtQd6i4+ebX0d JhkRFKe0mQv+dC5y6H3okkLfe75nMnLcckJ8InP7/lj/u19wjyuPu9sWK6WCu9Sp +gdI/SAEJFI81TDHzZ6JkQfzB4LbmjJNRIJE9UtgN/G/f2iSl/U/uH/F1k+qZbIE K29W1uijg1Faa66+n05siDqPkVml8DJ6I5r7oK7xwO658fbGepkKQvSXr+/M+QNi 90Qu3gsgY3Mf0GdAAoxc =Ru5g -----END PGP SIGNATURE-----