From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] fw_env: fix building w/out a config.h
Date: Tue, 21 May 2013 13:19:35 +0200 [thread overview]
Message-ID: <519B5847.4090701@denx.de> (raw)
In-Reply-To: <CANr=Z=ZXfCHu4a_+boaYHpvarG4x1qQcdtVABm8FJ_mufMD8-A@mail.gmail.com>
On 12/15/2012 07:04 PM, Joe Hershberger wrote:
<big snip>
>> -#ifndef CONFIG_BOOTCOMMAND
>> -#define CONFIG_BOOTCOMMAND \
>> - "bootp; " \
>> - "setenv bootargs root=/dev/nfs nfsroot=${serverip}:${rootpath} " \
>> - "ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:${hostname}::off; " \
>> - "bootm"
>> -#endif
>> -
>
> I agree that some of this should be cleaned up, but not as a result of
> removing the config.h.
>
>> extern int fw_printenv(int argc, char *argv[]);
>> extern char *fw_getenv (char *name);
>> extern int fw_setenv (int argc, char *argv[]);
>> --
>> 1.7.12.4
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> NAK
Mike, any chance that you might find some time to rework this patch for
mainline acceptance?
BTW: I'm using this patch for Yocto builds of the Linux environment
tools. Without it, building fails.
Thanks,
Stefan
next prev parent reply other threads:[~2013-05-21 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 5:47 [U-Boot] [PATCH 1/3] fw_env: fix type of len Mike Frysinger
2012-11-11 5:47 ` [U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT) Mike Frysinger
2012-12-14 8:25 ` Christian Riesch
2012-12-15 17:57 ` Joe Hershberger
2012-11-11 5:47 ` [U-Boot] [PATCH 3/3] fw_env: fix building w/out a config.h Mike Frysinger
2012-11-12 12:14 ` Peter Korsgaard
2012-12-15 18:04 ` Joe Hershberger
2013-05-21 11:19 ` Stefan Roese [this message]
2012-12-15 17:58 ` [U-Boot] [PATCH 1/3] fw_env: fix type of len Joe Hershberger
2012-12-19 23:00 ` [U-Boot] [U-Boot,1/3] " Tom Rini
2012-12-20 5:47 ` Joe Hershberger
2012-12-20 14:25 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B5847.4090701@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox