From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 22 May 2013 10:00:52 -0600 Subject: [U-Boot] [PATCH 2/3] env_mmc: allow negative CONFIG_ENV_OFFSET In-Reply-To: <20130522154658.GG10368@bill-the-cat> References: <1369167921-11311-1-git-send-email-swarren@wwwdotorg.org> <1369167921-11311-2-git-send-email-swarren@wwwdotorg.org> <20130522154658.GG10368@bill-the-cat> Message-ID: <519CEBB4.5020104@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/22/2013 09:46 AM, Tom Rini wrote: > On Tue, May 21, 2013 at 02:25:20PM -0600, Stephen Warren wrote: > >> From: Stephen Warren >> >> A negative value of CONFIG_ENV_OFFSET is treated as a backwards >> offset from the end of the eMMC device/partition, rather than a >> forwards offset from the start. >> >> This is useful when a single board may be stuffed with different >> eMMC devices, each of which has a different capacity, and you >> always want the environment to be stored at the very end of the >> device (or eMMC boot partition for example). >> >> One example of this case is NVIDIA's Ventana reference board. >> >> Signed-off-by: Stephen Warren > > NAK because you aren't also covering CONFIG_ENV_OFFSET_REDUND and > you need to update the README as it says ENV_OFFFSET is from the > beginning not end. env_mmc.c doesn't implement ENV_OFFSET_REDUND, and ENV_IS_IN_MMC isn't documented in the README (other config options like ENV_OFFSET are all documented relative to the ENV_IS_IN_xxx that defines their semantics in the README right now). Are you saying you want me to fix those issues before this series will be accepted? I have no way to test ENV_OFFSET_REDUND, so I really wouldn't want to implement that for MMC, although I guess that I could add the ENV_IS_IN_MMC section to the README if you need.