From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cfi_flash: Fix unaligned accesses to cfi_qry structure
Date: Thu, 23 May 2013 08:16:32 +0200 [thread overview]
Message-ID: <519DB440.3050206@denx.de> (raw)
In-Reply-To: <20130522205023.60b4cfef@lilith>
Hi Albert,
On 05/22/2013 08:50 PM, Albert ARIBAUD wrote:
<snip>
>> @@ -148,10 +152,10 @@ struct cfi_qry {
>> u8 block_erase_timeout_max;
>> u8 chip_erase_timeout_max;
>> u8 dev_size;
>> - u16 interface_desc;
>> - u16 max_buf_write_size;
>> + u16 interface_desc; /* aligned */
>> + u16 max_buf_write_size; /* aligned */
>> u8 num_erase_regions;
>> - u32 erase_region_info[NUM_ERASE_REGIONS];
>> + u32 erase_region_info[NUM_ERASE_REGIONS]; /* unaligned */
>> } __attribute__((packed));
>>
>> struct cfi_pri_hdr {
>
> Reviewed-By: Albert ARIBAUD <albert.u.boot@aribaud.net>
>
> Seems ok to me.
>
> Now, seeing as this is global to all architectures, yet motivated by
> ARM alignment considerations, which repo should this go to?
I'm responsible for cfi-flash. I'll look at it today.
Thanks,
Stefan
next prev parent reply other threads:[~2013-05-23 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 17:27 [U-Boot] [PATCH v2] cfi_flash: Fix unaligned accesses to cfi_qry structure Andrew Gabbasov
2013-05-22 18:50 ` Albert ARIBAUD
2013-05-23 6:16 ` Stefan Roese [this message]
2013-05-23 7:49 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519DB440.3050206@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox