public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers:lcd: fix unaligned access on lcd
Date: Fri, 24 May 2013 20:41:31 +0200	[thread overview]
Message-ID: <519FB45B.1080707@myspectrum.nl> (raw)
In-Reply-To: <1369381565-13946-1-git-send-email-p.wilczek@samsung.com>

Hello Piotr,

On 05/24/2013 09:46 AM, Piotr Wilczek wrote:
> This patch replace 'le32_to_cpu' function with 'get_unaligend_le32' to
> avoid unaligned access exception on some ARM platforms (ex Trats2).
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> CC: Anatolij Gustschin <agust@denx.de>
> ---
>   common/lcd.c |   12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> ntf("Error: only support 16 bpix");
If you use an aligned address + 2 as the BMP location, the aligned
accesses should work. If you have user input (which I doubt) you
can set CONFIG_SPLASHIMAGE_GUARD (see README).

The cm_t35 LCD thread has more info if you are interested.

Regards,
Jeroen

  parent reply	other threads:[~2013-05-24 18:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  7:46 [U-Boot] [PATCH] drivers:lcd: fix unaligned access on lcd Piotr Wilczek
2013-05-24 18:33 ` Wolfgang Denk
2013-05-27 11:35   ` Piotr Wilczek
2013-05-28  6:10     ` Nikita Kiryanov
2013-05-24 18:41 ` Jeroen Hofstee [this message]
2013-05-31 11:26 ` [U-Boot] [PATCH] lcd: align bmp header when uncopmressing image Piotr Wilczek
2013-05-31 14:22   ` Wolfgang Denk
2013-06-03  6:17     ` Piotr Wilczek
2013-06-03 11:15       ` Wolfgang Denk
2013-06-03 14:14         ` Piotr Wilczek
2013-06-03 18:45           ` Wolfgang Denk
2013-06-02 11:05   ` Nikita Kiryanov
2013-06-03  6:39     ` Piotr Wilczek
2013-06-03 11:18       ` Wolfgang Denk
2013-06-03 13:59   ` [U-Boot] [PATCH V2] " Piotr Wilczek
2013-06-03 18:44     ` Wolfgang Denk
2013-06-04 11:00     ` [U-Boot] [PATCH V3] " Piotr Wilczek
2013-06-04 15:05       ` Wolfgang Denk
2013-06-05  6:14       ` [U-Boot] [PATCH V4] " Piotr Wilczek
2013-07-01 18:51         ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519FB45B.1080707@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox