From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabor Juhos Date: Fri, 24 May 2013 20:55:40 +0200 Subject: [U-Boot] [PATCH v3 06/10] MIPS: qemu-malta: add PCI support In-Reply-To: <20130523154938.GC17119@bill-the-cat> References: <1369231066-15372-1-git-send-email-juhosg@openwrt.org> <1369231066-15372-7-git-send-email-juhosg@openwrt.org> <519E04BD.4030101@openwrt.org> <20130523154938.GC17119@bill-the-cat> Message-ID: <519FB7AC.5020403@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de 2013.05.23. 17:49 keltez?ssel, Tom Rini ?rta: <...> >>> The pci_indirect.c file is always compiled when CONFIG_PCI is defined >>> although it is not needed at all for Malta PCI support. >>> >>> The issue can be resolved on a few different ways: >>> >>> 1. Extend the '#if !defined(__I386__)' directive in pci_indirect.c with >>> a new '&& !defined(__MIPS__)' condition. This would be the simplest >>> solution but the drawback of this is that indirect support will not be >>> usable on any MIPS board. >>> >>> 2. Introduce a new 'CONFIG_PCI_INDIRECT_BRIDGE' option and only compile >>> the pci_indirect.c file if this option is present. Probably this is the >>> best solution however the new symbol should be added into the >>> configuration of the affected boards. >>> >>> 3. Introduce a new 'CONFIG_PCI_NO_INDIRECT_BRIDGE' option and use an >>> '#ifndef CONFIG_PCI_NO_INDIRECT_BRIDGE' directive in pci_indirect.c. >>> >>> I'm unsure about which approach is preferred. >>> >> >> I favor the second option. > > A quick check around in the kernel says that microblaze and powerpc have > similar type code and keep it under arch/ rather than drivers, but I'm good > with option #2. Ok, I will create a patch for that. Thanks, Gabor