[U-Boot] [PATCH] input: fix unaligned access in key_matrix_decode_fdt()

Simon Glass
2013-05-26T21:29:31Z

Hi Wolfgang,

On Sun, May 26, 2013 at 1:55 PM, Wolfgang Denk <wd@denx.de> wrote:

> Dear Simon Glass,
>
> In message <
> CAPnjgZ1_M-7EgGade-p-TLrYnPNNXGyh8zh32w8a2+2qGVYuow at mail.gmail.com> you
> wrote:
> >
> > Another problem I have is that the 'linux' in 'linux,keymap' in the
> device
> > compile turns into '1' since gcc predefines 'linux' to 1:
>
> Should this not be considered a GCC bug? After all, "linux" is not a
> reserved identifier. [Defining __linux, or __linux__ would be probab-
> ly OK, but "linux" or "arm" are not - IMO.]
>

It certainly surprised me, but if it is a bug, then it might be too late to
fix it, since that release is widespread.

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Der Horizont vieler Menschen ist ein Kreis mit Radius Null --
> und das nennen sie ihren Standpunkt.
>

That was worth translating :-)

Regards,
Simon