From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: OMAP5: clocks: Do not enable sgx clocks
Date: Wed, 29 May 2013 18:47:06 +0530 [thread overview]
Message-ID: <51A5FFD2.9090106@ti.com> (raw)
In-Reply-To: <20130529124015.GH11917@bill-the-cat>
On Wednesday 29 May 2013 06:10 PM, Tom Rini wrote:
> On Wed, May 29, 2013 at 03:39:54PM +0530, Lokesh Vutla wrote:
>
>> From: Sricharan R <r.sricharan@ti.com>
>>
>> SGX clocks should be enabled only for OMAP5 ES1.0.
>> So this can be removed.
>>
>> Signed-off-by: Sricharan R <r.sricharan@ti.com>
>> ---
>> arch/arm/cpu/armv7/omap5/hw_data.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
>> index 604fa42..842cf27 100644
>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
>> @@ -383,12 +383,6 @@ void enable_basic_clocks(void)
>> clk_modules_explicit_en_essential,
>> 1);
>>
>> - /* Select 384Mhz for GPU as its the POR for ES1.0 */
>> - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl,
>> - CLKSEL_GPU_HYD_GCLK_MASK);
>> - setbits_le32((*prcm)->cm_sgx_sgx_clkctrl,
>> - CLKSEL_GPU_CORE_GCLK_MASK);
>> -
>> /* Enable SCRM OPT clocks for PER and CORE dpll */
>> setbits_le32((*prcm)->cm_wkupaon_scrm_clkctrl,
>> OPTFCLKEN_SCRM_PER_MASK);
> Wait, will everyone with ES1.0 be updating to ES2.0 and be OK with this?
> Lubomir's board is ES1.0, currently. Thanks!
Even if so, these clocks should/need not be enabled in boot loader.
It should not have been enabled in, but earlier we had the habit
enabling unnessecary things..
Regards,
Sricharan
next prev parent reply other threads:[~2013-05-29 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 10:09 [U-Boot] [PATCH 0/3] ARM: OMAP4+: Misc Cleanup Lokesh Vutla
2013-05-29 10:09 ` [U-Boot] [PATCH 1/3] ARM: OMAP4+: Cleanup header files Lokesh Vutla
2013-05-29 10:09 ` [U-Boot] [PATCH 2/3] ARM: OMAP5: clocks: Do not enable sgx clocks Lokesh Vutla
2013-05-29 12:40 ` Tom Rini
2013-05-29 13:17 ` Sricharan R [this message]
2013-05-29 10:09 ` [U-Boot] [PATCH 3/3] ARM: OMAP4+: pmic: Make generic bus init and write functions Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5FFD2.9090106@ti.com \
--to=r.sricharan@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox