From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5] ARM: OMAP: I2C: New read, write and probe functions
Date: Mon, 03 Jun 2013 07:15:06 +0200 [thread overview]
Message-ID: <51AC265A.6050608@denx.de> (raw)
In-Reply-To: <20130602130856.GD9556@bill-the-cat>
Hello Tom,
Am 02.06.2013 15:08, schrieb Tom Rini:
> On Sun, Jun 02, 2013 at 07:20:50AM +0200, Heiko Schocher wrote:
>> Hello Lubomir,
>>
>> Am 01.06.2013 18:44, schrieb Lubomir Popov:
>>> New i2c_read, i2c_write and i2c_probe functions, tested on OMAP4
>>> (4430/60/70), OMAP5 (5430) and AM335X (3359); should work on older
>>> OMAPs and derivatives as well. The only anticipated exception would
>>> be the OMAP2420, which shall require driver modification.
[...9
>> Just one comment:
>> Your patch has 9 checkpatch warnings which are all lines
>> (printf strings) over 80 chars ... some with lines > 110
>> characters ... I know, tom gave you a OK for this ... I am
>> also unhappy with splitting a printf-string over 2 or more lines ...
>> but we have this 80 characters rule ... Wolfgang, what do you
>> think? Should we loosen this rule for printf-strings?
>
> We have loosened the rule for printf strings already, in order to make
> it easier for tracking down error messages. However, checkpatch needs
> tweaking at times for our print functions vs kernel print functions.
Ok, great, missed that, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2013-06-03 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 16:44 [U-Boot] [PATCH V5] ARM: OMAP: I2C: New read, write and probe functions Lubomir Popov
2013-06-02 5:20 ` Heiko Schocher
2013-06-02 11:42 ` Lubomir Popov
2013-06-03 5:13 ` Heiko Schocher
2013-06-04 4:26 ` Heiko Schocher
2013-06-04 6:49 ` Lubomir Popov
2013-06-04 7:03 ` Heiko Schocher
2013-06-04 21:38 ` Tom Rini
2013-06-02 13:08 ` Tom Rini
2013-06-03 5:15 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC265A.6050608@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox