From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add splash screen support via loading from flash
Date: Mon, 03 Jun 2013 09:44:28 +0200 [thread overview]
Message-ID: <51AC495C.5040003@denx.de> (raw)
In-Reply-To: <1369947781-25077-1-git-send-email-robert.winkler@boundarydevices.com>
Hi Robert,
On 30/05/2013 23:03, Robert Winkler wrote:
> Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
> ---
> board/boundary/nitrogen6x/nitrogen6x.c | 22 ++++++++++++++++++++++
> include/configs/nitrogen6x.h | 11 ++++++++++-
> 2 files changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
> index 3b228cf..648b877 100644
> --- a/board/boundary/nitrogen6x/nitrogen6x.c
> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> @@ -401,6 +401,24 @@ int board_eth_init(bd_t *bis)
> return 0;
> }
>
> +
> +void splash_screen_prepare(void)
> +{
> + char *env_loadsplash;
> +
> + if (!getenv("splashimage") || !getenv("splashsize"))
> + return;
> +
> + env_loadsplash = getenv("loadsplash");
> + if (!env_loadsplash) {
> + printf("Environment variable loadsplash not found!\n");
> + return;
> + }
> +
> + if (run_command_list(env_loadsplash, -1, 0))
> + printf("failed to run loadsplash %s\n\n", env_loadsplash);
> +}
> +
Which is the advantage instead of using the "preboot" variable setting
CONFIG_PREBOOT ? It does pretty the same and you can move the whole
script outside of board code.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-06-03 7:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 21:03 [U-Boot] [PATCH] Add splash screen support via loading from flash Robert Winkler
2013-05-30 23:32 ` Wolfgang Denk
2013-05-31 0:01 ` Robert Winkler
2013-05-31 7:49 ` Wolfgang Denk
2013-05-31 17:50 ` Robert Winkler
2013-06-03 7:44 ` Stefano Babic [this message]
2013-06-03 16:34 ` Robert Winkler
2013-06-04 13:44 ` Stefano Babic
2013-06-04 13:55 ` Eric Nelson
2013-06-04 14:15 ` Stefano Babic
2013-06-04 14:30 ` Eric Nelson
2013-06-04 14:57 ` Robert Winkler
2013-06-04 15:08 ` Stefano Babic
2013-06-04 15:05 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC495C.5040003@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox