From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Mon, 03 Jun 2013 09:44:28 +0200
Subject: [U-Boot] [PATCH] Add splash screen support via loading from
	flash
In-Reply-To: <1369947781-25077-1-git-send-email-robert.winkler@boundarydevices.com>
References: <1369947781-25077-1-git-send-email-robert.winkler@boundarydevices.com>
Message-ID: <51AC495C.5040003@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Robert,


On 30/05/2013 23:03, Robert Winkler wrote:
> Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
> ---
>  board/boundary/nitrogen6x/nitrogen6x.c | 22 ++++++++++++++++++++++
>  include/configs/nitrogen6x.h           | 11 ++++++++++-
>  2 files changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
> index 3b228cf..648b877 100644
> --- a/board/boundary/nitrogen6x/nitrogen6x.c
> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> @@ -401,6 +401,24 @@ int board_eth_init(bd_t *bis)
>  	return 0;
>  }
>  
> +
> +void splash_screen_prepare(void)
> +{
> +	char *env_loadsplash;
> +
> +	if (!getenv("splashimage") || !getenv("splashsize"))
> +		return;
> +
> +	env_loadsplash = getenv("loadsplash");
> +	if (!env_loadsplash) {
> +		printf("Environment variable loadsplash not found!\n");
> +		return;
> +	}
> +
> +	if (run_command_list(env_loadsplash, -1, 0))
> +		printf("failed to run loadsplash %s\n\n", env_loadsplash);
> +}
> +


Which is the advantage instead of using the "preboot" variable setting
CONFIG_PREBOOT ? It does pretty the same and you can move the whole
script outside of board code.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================