From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Add support for Wandboard quad.
Date: Mon, 03 Jun 2013 11:28:06 +0200 [thread overview]
Message-ID: <51AC61A6.9050609@denx.de> (raw)
In-Reply-To: <20130528160435.51fb4668@triceratops>
Hi Tapani,
On 28/05/2013 10:04, Tapani Utriainen wrote:
>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
> ---
Due to increased memory, a warning is generated for wandboard_quad:
wandboard.c: In function 'dram_init':
wandboard.c:47:31: warning: integer overflow in expression [-Woverflow]
It is better to fix it directly into this patch. Can you fix it by
casting to phys_size_t and resubmit ?
gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;
By the way, I forget why it is not possible to use get_ram_size() here.
I know this is not part of this patch (could be done later), but any
hints why we cannot use as usual get_ram_size() in dram_init ?
Thanks,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-06-03 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 8:04 [U-Boot] [PATCH v2] Add support for Wandboard quad Tapani Utriainen
2013-05-28 12:22 ` Otavio Salvador
2013-06-03 9:28 ` Stefano Babic [this message]
2013-06-03 11:21 ` Wolfgang Denk
2013-06-03 11:25 ` Otavio Salvador
2013-06-03 13:01 ` Wolfgang Denk
2013-06-20 13:26 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC61A6.9050609@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox