From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 03 Jun 2013 13:27:07 +0200 Subject: [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal In-Reply-To: <1369925258-13834-1-git-send-email-andrew_gabbasov@mentor.com> References: <1369925258-13834-1-git-send-email-andrew_gabbasov@mentor.com> Message-ID: <51AC7D8B.6010408@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 30/05/2013 16:47, Andrew Gabbasov wrote: > The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro > (shifted and or'ed with chip select), so it's incorrect to pass > that macro directly as an argument to gpio_direction_output() call. > > Also, SPI driver sets the direction and initial value of a gpio, > used as a chip select signal, before any actual activity happens > on the bus. > > So, it is safe to just remove the gpio_direction_output call, > that works incorrectly, thus making no effect, anyway. > > Signed-off-by: Andrew Gabbasov > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================