* [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal
@ 2013-05-30 14:47 Andrew Gabbasov
2013-05-30 22:35 ` Robert Winkler
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrew Gabbasov @ 2013-05-30 14:47 UTC (permalink / raw)
To: u-boot
The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
(shifted and or'ed with chip select), so it's incorrect to pass
that macro directly as an argument to gpio_direction_output() call.
Also, SPI driver sets the direction and initial value of a gpio,
used as a chip select signal, before any actual activity happens
on the bus.
So, it is safe to just remove the gpio_direction_output call,
that works incorrectly, thus making no effect, anyway.
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
---
board/boundary/nitrogen6x/nitrogen6x.c | 1 -
board/freescale/mx6qsabrelite/mx6qsabrelite.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
index cc071d6..735fd76 100644
--- a/board/boundary/nitrogen6x/nitrogen6x.c
+++ b/board/boundary/nitrogen6x/nitrogen6x.c
@@ -342,7 +342,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
void setup_spi(void)
{
- gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
ARRAY_SIZE(ecspi1_pads));
}
diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
index 9f9cac8..29815d7 100644
--- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
+++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
@@ -312,7 +312,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
void setup_spi(void)
{
- gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
ARRAY_SIZE(ecspi1_pads));
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal
2013-05-30 14:47 [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal Andrew Gabbasov
@ 2013-05-30 22:35 ` Robert Winkler
2013-05-31 5:19 ` Dirk Behme
2013-06-03 11:27 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Robert Winkler @ 2013-05-30 22:35 UTC (permalink / raw)
To: u-boot
On Thu, May 30, 2013 at 7:47 AM, Andrew Gabbasov <andrew_gabbasov@mentor.com
> wrote:
> The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
> (shifted and or'ed with chip select), so it's incorrect to pass
> that macro directly as an argument to gpio_direction_output() call.
>
> Also, SPI driver sets the direction and initial value of a gpio,
> used as a chip select signal, before any actual activity happens
> on the bus.
>
> So, it is safe to just remove the gpio_direction_output call,
> that works incorrectly, thus making no effect, anyway.
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> ---
> board/boundary/nitrogen6x/nitrogen6x.c | 1 -
> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c
> b/board/boundary/nitrogen6x/nitrogen6x.c
> index cc071d6..735fd76 100644
> --- a/board/boundary/nitrogen6x/nitrogen6x.c
> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> @@ -342,7 +342,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
>
> void setup_spi(void)
> {
> - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
> ARRAY_SIZE(ecspi1_pads));
> }
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 9f9cac8..29815d7 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -312,7 +312,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
>
> void setup_spi(void)
> {
> - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
> ARRAY_SIZE(ecspi1_pads));
> }
> --
> 1.7.10.4
>
> Works for me for all Tegra builds, so:
Tested-by: Robert Winkler <robert.winkler@boundarydevices.com>
Tested on the Sabre Lite.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal
2013-05-30 14:47 [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal Andrew Gabbasov
2013-05-30 22:35 ` Robert Winkler
@ 2013-05-31 5:19 ` Dirk Behme
2013-06-03 11:27 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Dirk Behme @ 2013-05-31 5:19 UTC (permalink / raw)
To: u-boot
On 30.05.2013 16:47, Andrew Gabbasov wrote:
> The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
> (shifted and or'ed with chip select), so it's incorrect to pass
> that macro directly as an argument to gpio_direction_output() call.
>
> Also, SPI driver sets the direction and initial value of a gpio,
> used as a chip select signal, before any actual activity happens
> on the bus.
>
> So, it is safe to just remove the gpio_direction_output call,
> that works incorrectly, thus making no effect, anyway.
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> ---
> board/boundary/nitrogen6x/nitrogen6x.c | 1 -
> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
> index cc071d6..735fd76 100644
> --- a/board/boundary/nitrogen6x/nitrogen6x.c
> +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> @@ -342,7 +342,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
>
> void setup_spi(void)
> {
> - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
> ARRAY_SIZE(ecspi1_pads));
> }
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 9f9cac8..29815d7 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -312,7 +312,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = {
>
> void setup_spi(void)
> {
> - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads,
> ARRAY_SIZE(ecspi1_pads));
> }
>
Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
Thanks
Dirk
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal
2013-05-30 14:47 [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal Andrew Gabbasov
2013-05-30 22:35 ` Robert Winkler
2013-05-31 5:19 ` Dirk Behme
@ 2013-06-03 11:27 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-06-03 11:27 UTC (permalink / raw)
To: u-boot
On 30/05/2013 16:47, Andrew Gabbasov wrote:
> The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
> (shifted and or'ed with chip select), so it's incorrect to pass
> that macro directly as an argument to gpio_direction_output() call.
>
> Also, SPI driver sets the direction and initial value of a gpio,
> used as a chip select signal, before any actual activity happens
> on the bus.
>
> So, it is safe to just remove the gpio_direction_output call,
> that works incorrectly, thus making no effect, anyway.
>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-03 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 14:47 [U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal Andrew Gabbasov
2013-05-30 22:35 ` Robert Winkler
2013-05-31 5:19 ` Dirk Behme
2013-06-03 11:27 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox