From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5] ARM: OMAP: I2C: New read, write and probe functions
Date: Tue, 04 Jun 2013 06:26:58 +0200 [thread overview]
Message-ID: <51AD6C92.1040408@denx.de> (raw)
In-Reply-To: <51AC2607.3000209@denx.de>
Hello Lubomir,
Am 03.06.2013 07:13, schrieb Heiko Schocher:
> Hello Lubomir,
>
> Am 02.06.2013 13:42, schrieb Lubomir Popov:
>>> Hello Lubomir,
>>>
>>> Am 01.06.2013 18:44, schrieb Lubomir Popov:
>>>> New i2c_read, i2c_write and i2c_probe functions, tested on OMAP4
>>>> (4430/60/70), OMAP5 (5430) and AM335X (3359); should work on older
>>>> OMAPs and derivatives as well. The only anticipated exception would
>>>> be the OMAP2420, which shall require driver modification.
> [...]
>>>> drivers/i2c/omap24xx_i2c.c | 490 +++++++++++++++++++++++++++------------------
>>>> 1 file changed, 299 insertions(+), 191 deletions(-)
>>>
>>> Tested on 3 arm335x based boards, which one uses i2c in SPL
>>> code for getting ram parameters, so:
>>>
>>> Tested-by: Heiko Schocher <hs@denx.de>
>> Many thanks for testing, to Tom as well (he did it on the
>> Beagleboards, but for one of the older versions, V3 I believe,
>> right?).
>> When it comes to versions, I see that V1 and V2 are still listed
>> in patchwork, probably because of slightly different wording of
>> the subject:
>> http://patchwork.ozlabs.org/patch/233823/
>> http://patchwork.ozlabs.org/patch/246204/
>> Could you or Tom clean this up, please? Thanks.
>
> Cleared the v3 v4 version, but missed the v2 and v1, Done.
just doing a "MAKEALL arm" with your patch applied and get this error:
Configuring for omap2420h4 board...
omap24xx_i2c.c:497:17: error: 'struct i2c' has no member named 'irqstatus_raw'
omap24xx_i2c.c:528:12: error: 'struct i2c' has no member named 'irqstatus_raw'
arm-linux-gnueabi-size: './u-boot': No such file
omap24xx_i2c.c: In function 'wait_for_bb':
omap24xx_i2c.c:497:17: error: 'struct i2c' has no member named 'irqstatus_raw'
omap24xx_i2c.c: In function 'wait_for_event':
omap24xx_i2c.c:528:12: error: 'struct i2c' has no member named 'irqstatus_raw'
make[1]: *** [omap24xx_i2c.o] Fehler 1
make: *** [drivers/i2c/libi2c.o] Fehler 2
make: *** Warte auf noch nicht beendete Prozesse...
Please fix this and run a "MAKEALL arm" before repost, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2013-06-04 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 16:44 [U-Boot] [PATCH V5] ARM: OMAP: I2C: New read, write and probe functions Lubomir Popov
2013-06-02 5:20 ` Heiko Schocher
2013-06-02 11:42 ` Lubomir Popov
2013-06-03 5:13 ` Heiko Schocher
2013-06-04 4:26 ` Heiko Schocher [this message]
2013-06-04 6:49 ` Lubomir Popov
2013-06-04 7:03 ` Heiko Schocher
2013-06-04 21:38 ` Tom Rini
2013-06-02 13:08 ` Tom Rini
2013-06-03 5:15 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD6C92.1040408@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox