From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] exynos: i2c: Use generic api to get i2c clk freq
Date: Tue, 04 Jun 2013 17:01:15 +0900 [thread overview]
Message-ID: <51AD9ECB.60508@samsung.com> (raw)
In-Reply-To: <1364202173-13719-1-git-send-email-akshay.s@samsung.com>
On 25/03/13 18:02, Akshay Saraswat wrote:
> From: Padmavathi Venna <padma.v@samsung.com>
>
> Use generic api to get the i2c clock frequency.
> Tested on smdk5250 with the help of following commands.
> run
> i2c dev 1
> i2c dev 2
> i2c speed
>
> This patch depends on:
> http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/154930
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
> ---
> drivers/i2c/s3c24x0_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c
> index 769a2ba..a9f19e7 100644
> --- a/drivers/i2c/s3c24x0_i2c.c
> +++ b/drivers/i2c/s3c24x0_i2c.c
> @@ -151,7 +151,7 @@ static void i2c_ch_init(struct s3c24x0_i2c *i2c, int speed, int slaveadd)
> {
> ulong freq, pres = 16, div;
> #if (defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5)
> - freq = get_i2c_clk();
> + freq = clock_get_periph_rate(PERIPH_ID_I2C0);
Since clock_get_periph_rate did not implemented on exynos4, exynos4 will get zero.
So, I'll not accept this patch.
> #else
> freq = get_PCLK();
> #endif
>
Thanks,
Minkyu Kang.
prev parent reply other threads:[~2013-06-04 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 9:02 [U-Boot] [PATCH] exynos: i2c: Use generic api to get i2c clk freq Akshay Saraswat
2013-03-25 9:02 ` [U-Boot] [PATCH] exynos: uart: Use generic api to the uart " Akshay Saraswat
2013-06-04 8:02 ` Minkyu Kang
2013-06-04 7:53 ` [U-Boot] [PATCH] exynos: i2c: Use generic api to get i2c " Minkyu Kang
2013-06-04 8:01 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD9ECB.60508@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox