public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add splash screen support via loading from flash
Date: Tue, 04 Jun 2013 15:44:22 +0200	[thread overview]
Message-ID: <51ADEF36.2000505@denx.de> (raw)
In-Reply-To: <CAMDMJ5M3=YqAqGE3vTv6e39rSm1w2Q8bgFyXyX3mfdEjgBho6Q@mail.gmail.com>

Hi Robert,

On 03/06/2013 18:34, Robert Winkler wrote:

>> Which is the advantage instead of using the "preboot" variable setting
>> CONFIG_PREBOOT ? It does pretty the same and you can move the whole
>> script outside of board code.
> 
> The preboot command is run too late.  It looks like it is run in
> main_loop but U-Boot looks for the splash image
> at the address in the splashimage variable in board_init_r ->
> stdio_init -> drv_lcd_init or drv_video_init (depending on
> whether you have CONFIG_LCD or CONFIG_VIDEO).

You are describing a bug - then it should be fixed globally, not only
for this board.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-06-04 13:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 21:03 [U-Boot] [PATCH] Add splash screen support via loading from flash Robert Winkler
2013-05-30 23:32 ` Wolfgang Denk
2013-05-31  0:01   ` Robert Winkler
2013-05-31  7:49     ` Wolfgang Denk
2013-05-31 17:50       ` Robert Winkler
2013-06-03  7:44 ` Stefano Babic
2013-06-03 16:34   ` Robert Winkler
2013-06-04 13:44     ` Stefano Babic [this message]
2013-06-04 13:55       ` Eric Nelson
2013-06-04 14:15         ` Stefano Babic
2013-06-04 14:30           ` Eric Nelson
2013-06-04 14:57             ` Robert Winkler
2013-06-04 15:08               ` Stefano Babic
2013-06-04 15:05             ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ADEF36.2000505@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox