From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Tue, 04 Jun 2013 06:55:02 -0700
Subject: [U-Boot] [PATCH] Add splash screen support via loading from
	flash
In-Reply-To: <51ADEF36.2000505@denx.de>
References: <1369947781-25077-1-git-send-email-robert.winkler@boundarydevices.com>
	<51AC495C.5040003@denx.de>
	<CAMDMJ5M3=YqAqGE3vTv6e39rSm1w2Q8bgFyXyX3mfdEjgBho6Q@mail.gmail.com>
	<51ADEF36.2000505@denx.de>
Message-ID: <51ADF1B6.7020307@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

On 06/04/2013 06:44 AM, Stefano Babic wrote:
> Hi Robert,
>
> On 03/06/2013 18:34, Robert Winkler wrote:
>
>>> Which is the advantage instead of using the "preboot" variable setting
>>> CONFIG_PREBOOT ? It does pretty the same and you can move the whole
>>> script outside of board code.
>>
>> The preboot command is run too late.  It looks like it is run in
>> main_loop but U-Boot looks for the splash image
>> at the address in the splashimage variable in board_init_r ->
>> stdio_init -> drv_lcd_init or drv_video_init (depending on
>> whether you have CONFIG_LCD or CONFIG_VIDEO).
>
> You are describing a bug - then it should be fixed globally, not only
> for this board.
>

What's the bug?
	- preboot being called too late, or
	- splash_screen_prepare() being called too early

It seems that having splash_screen_prepare() called early
makes sense, because stdout could be set to include VGA
and having access to stdout is very useful in preboot
commands.

Please advise,


Eric