[U-Boot] [PATCH] Add splash screen support via loading from flash

Robert Winkler
2013-05-31T00:01:45Z

On Thu, May 30, 2013 at 4:32 PM, Wolfgang Denk <wd@denx.de> wrote:

> Dear Robert Winkler,
>
> In message <
> 1369947781-25077-1-git-send-email-robert.winkler at boundarydevices.com> you
> wrote:
> > Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
> > ---
> > board/boundary/nitrogen6x/nitrogen6x.c | 22 ++++++++++++++++++++++
> > include/configs/nitrogen6x.h | 11 ++++++++++-
> > 2 files changed, 32 insertions(+), 1 deletion(-)
>
> Could you please explain why you need custom code here?
>

I originally tried to use the CONFIG_SPLASH_SCREEN_PREPARE functionality.
After some frustration, I figured out that without CONFIG_LCD, it is never
actually called.
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=blob;f=common/stdio.c;h=5d5117c0ed838195a2caad7c28c128247771cd92;hb=HEAD#l216

It does seem odd that there are 2 totally different paths and the other
splash screen related macros are used in both but the prepare function is
only called in the LCD case.

Since we use CONFIG_VIDEO and not CONFIG_LCD, this seemed to be the best,
or at least the least invasive, solution.

>
> What exactly cannot be done wioth the existing features?
>
>
> BTW: it would be nice if you flag board specific code in the Subject:,
> and it is considered mandatory to Cc: the respective board maintainer.
>

I apologize for that. I'm new and didn't know till after I'd already sent
it. I did CC the board maintainer, Eric. We also went over the code in
person.

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Doubt isn't the opposite of faith; it is an element of faith.
> - Paul Tillich, German theologian and historian
>