[U-Boot] [PATCH] Add splash screen support via loading from flash

Eric Nelson
2013-06-04T13:55:02Z

Hi Stefano,

On 06/04/2013 06:44 AM, Stefano Babic wrote:
> Hi Robert,
>
> On 03/06/2013 18:34, Robert Winkler wrote:
>
>>> Which is the advantage instead of using the "preboot" variable setting
>>> CONFIG_PREBOOT ? It does pretty the same and you can move the whole
>>> script outside of board code.
>>
>> The preboot command is run too late. It looks like it is run in
>> main_loop but U-Boot looks for the splash image
>> at the address in the splashimage variable in board_init_r ->
>> stdio_init -> drv_lcd_init or drv_video_init (depending on
>> whether you have CONFIG_LCD or CONFIG_VIDEO).
>
> You are describing a bug - then it should be fixed globally, not only
> for this board.
>

What's the bug?
- preboot being called too late, or
- splash_screen_prepare() being called too early

It seems that having splash_screen_prepare() called early
makes sense, because stdout could be set to include VGA
and having access to stdout is very useful in preboot
commands.

Please advise,

Eric